bootstrap: apply most of clippy's suggestions #121340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @onur-ozkan rustbot has assigned @onur-ozkan. Use r? to explicitly pick a reviewer |
rustbot
added
S-waiting-on-review
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. This PR modifies If appropriate, please update |
onur-ozkan
reviewed
Feb 20, 2024
src/bootstrap/src/utils/tarball.rs
Outdated
| @@ -8,6 +8,7 @@ use crate::core::builder::Builder; | |||
| use crate::utils::channel; | |||
| use crate::utils::helpers::t; | |||
|
|
|||
| #[allow(clippy::upper_case_acronyms)] | |||
There was a problem hiding this comment.
You don't need to allow these rules
src/bootstrap/src/utils/helpers.rs
Outdated
Comment on lines
553
to
556
| let input = input.as_ref(); | ||
| let mut result = String::with_capacity(input.len() * 2); | ||
| input.iter().for_each(|x| write!(result, "{:02x}", x).unwrap()); | ||
| result |
There was a problem hiding this comment.
This makes it much complicated. Please revert this too.
| @@ -573,6 +574,7 @@ impl Step for LldWrapper { | |||
| run.never() | |||
| } | |||
|
|
|||
| #[allow(clippy::let_and_return)] | |||
There was a problem hiding this comment.
Please revert all the #[allow.. parts
GrigorenkoPV
force-pushed
the
bootstrap-clippy
branch
from
8e8ca85
to
0009251
Compare
onur-ozkan
approved these changes
Feb 20, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #121345) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
GrigorenkoPV
force-pushed
the
bootstrap-clippy
branch
from
0009251
to
ae3f4f1
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 20, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#119203 (Correct the simd_masked_{load,store} intrinsic docs) - rust-lang#121277 (Refactor trait implementations in `core::convert::num`.) - rust-lang#121322 (Don't ICE when hitting overflow limit in fulfillment loop in next solver) - rust-lang#121323 (Don't use raw parameter types in `find_builder_fn`) - rust-lang#121344 (Expand weak alias types before collecting constrained/referenced late bound regions + refactorings) - rust-lang#121350 (Fix stray trait mismatch in `resolve_associated_item` for `AsyncFn`) - rust-lang#121352 (docs: add missing "the" to `str::strip_prefix` doc) Failed merges: - rust-lang#121340 (bootstrap: apply most of clippy's suggestions) r? `@ghost` `@rustbot` modify labels: rollup
|
@rustbot review |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#121044 (Support async trait bounds in macros) - rust-lang#121175 (match lowering: test one or pattern at a time) - rust-lang#121340 (bootstrap: apply most of clippy's suggestions) - rust-lang#121347 (compiletest: support auxiliaries with auxiliaries) - rust-lang#121359 (miscellaneous type system improvements) - rust-lang#121366 (Remove `diagnostic_builder.rs`) - rust-lang#121379 (Remove an `unchecked_error_guaranteed` call.) - rust-lang#121396 (make it possible for outside crates to inspect a mir::ConstValue with the interpreter) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Rollup merge of rust-lang#121340 - GrigorenkoPV:bootstrap-clippy, r=onur-ozkan bootstrap: apply most of clippy's suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.