Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtree update of rustc_codegen_gcc #121390

Conversation

GuillaumeGomez
Copy link
Member

No description provided.

antoyo and others added 30 commits November 19, 2023 13:42
The `fluent_messages!` macro produces uses of
`crate::{D,Subd}iagnosticMessage`, which means that every crate using
the macro must have this import:
```
use rustc_errors::{DiagnosticMessage, SubdiagnosticMessage};
```

This commit changes the macro to instead use
`rustc_errors::{D,Subd}iagnosticMessage`, which avoids the need for the
imports.
Currently we always do this:
```
use rustc_fluent_macro::fluent_messages;
...
fluent_messages! { "./example.ftl" }
```
But there is no need, we can just do this everywhere:
```
rustc_fluent_macro::fluent_messages! { "./example.ftl" }
```
which is shorter.
Implements lane-local byte swapping through vector shuffles.  While this
is more setup than non-vector shuffles, this implementation can shuffle
multiple integers concurrently.

Signed-off-by: Andy Sadler <andrewsadler122@gmail.com>
Signed-off-by: Andy Sadler <andrewsadler122@gmail.com>
The simd intrinsic handler was delegating implementation of `simd_frem`
to `Builder::frem`, which wasn't able to handle vector-typed inputs.  To
fix this, teach this method how to handle vector inputs.

Signed-off-by: Andy Sadler <andrewsadler122@gmail.com>
If we're running against a patched libgccjit, use an algorithm similar
to what LLVM uses for this intrinsic.  Otherwise, fallback to a
per-element bitreverse.

Signed-off-by: Andy Sadler <andrewsadler122@gmail.com>
Signed-off-by: Andy Sadler <andrewsadler122@gmail.com>
gcc_not would panic upon encountering a vector type, which is not what
we want here.

Signed-off-by: Andy Sadler <andrewsadler122@gmail.com>
This test now passes when tested with a patched libgccjit.  However, due
to [some compiler bugs][1], we can't enable this for non-patched
libgccjit yet.

[1]: https://github.com/sadlerap/rustc_codegen_gcc/actions/runs/6820180639/job/18548672444#step:15:4375

Signed-off-by: Andy Sadler <andrewsadler122@gmail.com>
`sess` is a terribly misleading name for a `Handler`! This confused me
for a bit.
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the subtree-update_cg_gcc_2024-02-21 branch from 0024930 to 812c1f8 Compare March 2, 2024 17:06
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the subtree-update_cg_gcc_2024-02-21 branch from 812c1f8 to b0b8940 Compare March 2, 2024 17:11
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the subtree-update_cg_gcc_2024-02-21 branch from b0b8940 to 9e40b1c Compare March 2, 2024 17:24
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the subtree-update_cg_gcc_2024-02-21 branch from 9e40b1c to 1419e70 Compare March 2, 2024 19:36
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the subtree-update_cg_gcc_2024-02-21 branch from 1419e70 to ccd0e7d Compare March 2, 2024 19:42
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the subtree-update_cg_gcc_2024-02-21 branch from ccd0e7d to a4c1195 Compare March 3, 2024 15:02
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the subtree-update_cg_gcc_2024-02-21 branch from a4c1195 to 31789e5 Compare March 3, 2024 15:26
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the subtree-update_cg_gcc_2024-02-21 branch from 31789e5 to 391bb9c Compare March 3, 2024 15:39
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the subtree-update_cg_gcc_2024-02-21 branch from 391bb9c to 3567f84 Compare March 3, 2024 15:43
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the subtree-update_cg_gcc_2024-02-21 branch 2 times, most recently from 6c43bce to 800737c Compare March 3, 2024 22:01
@bors
Copy link
Contributor

bors commented Mar 4, 2024

☔ The latest upstream changes (presumably #121665) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez GuillaumeGomez force-pushed the subtree-update_cg_gcc_2024-02-21 branch from 800737c to bda09e1 Compare March 4, 2024 14:30
@GuillaumeGomez GuillaumeGomez deleted the subtree-update_cg_gcc_2024-02-21 branch March 5, 2024 19:00
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
…_2024-03-05, r=MarkSimulacrum

Subtree update cg gcc 2024 03 05

Reopening of rust-lang#121390.

r? `@ghost`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet