fix attribute validation on associated items in traits #121545

gvozdvmozgu · 2024-02-24T13:23:39Z

#121537, fixed attribute validation on associated items in traits

rustbot · 2024-02-24T13:23:47Z

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

fmease · 2024-02-24T14:37:13Z

Not sure why @nnethercote's PR started to trigger an ICE (I don't have time to investigate) but I've been aware of the missing attr visit call for some time already (cc #119924 where I mention it).

r? fmease

fmease · 2024-02-24T14:39:00Z

Since this makes the reproducer and likely many other snippets go from pass on stable to error on this branch this means it's a breaking change (ignoring the ICE on nightly).
I'm therefore gonna check crater.

@bors try

bors · 2024-02-24T14:40:08Z

⌛ Trying commit 8b576d5 with merge 7ee7645...

…-associated-items, r=<try> fix attribute validation on associated items in traits rust-lang#121537, fixed attribute validation on associated items in traits

bors · 2024-02-24T16:27:01Z

☀️ Try build successful - checks-actions
Build commit: 7ee7645 (7ee76453dd3eae6de6c1351f26482bed63b01beb)

fmease · 2024-02-24T16:37:44Z

@craterbot check

craterbot · 2024-02-24T16:37:53Z

👌 Experiment pr-121545 created and queued.
🤖 Automatically detected try build 7ee7645
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

nnethercote · 2024-02-25T21:31:14Z

Not sure why @nnethercote's PR started to trigger an ICE

That's easy: I added a let guar = self.dcx().has_errors().unwrap(); here

In hindsight, perhaps a span_delayed_bug would have been more appropriate, but this problem would have shown up anyway.

I've been aware of the missing attr visit call for some time already (cc #119924 where I mention it).

So I guess we can call #121120 a success, because it (re-)exposed this AST validation problem.

craterbot · 2024-03-05T16:12:47Z

🚧 Experiment pr-121545 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2024-03-08T21:51:35Z

🎉 Experiment pr-121545 is completed!
📊 6 regressed and 1 fixed (420397 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

fmease · 2024-03-11T13:02:38Z

Thanks @gvozdvmozgu for submitting a fix to async_ui! I will go through the crater report one more time later to check if any of the error/build-fail→error/build-fail entries are “#121607 situations” because those would also need to be counted as regressions.

fmease · 2024-03-16T21:46:32Z

JakeDawkins.graphql-client-302-repro is spurious btw.
Ok, I think we're good.

fmease · 2024-03-16T21:46:37Z

@bors r+

bors · 2024-03-16T21:46:40Z

📌 Commit 8b576d5 has been approved by fmease

It is now in the queue for this repository.

Rollup of 9 pull requests Successful merges: - rust-lang#117918 (Add `wasm_c_abi` `future-incompat` lint) - rust-lang#121545 (fix attribute validation on associated items in traits) - rust-lang#121720 (Split refining_impl_trait lint into _reachable, _internal variants) - rust-lang#122270 (fix `long-linker-command-lines` failure caused by `rust.rpath=false`) - rust-lang#122564 (Delegation: fix ICE on duplicated associative items) - rust-lang#122577 (Remove obsolete parameter `speculative` from `instantiate_poly_trait_ref`) - rust-lang#122601 (Optimize `ptr::replace`) - rust-lang#122604 (Mention jieyouxu for changes to compiletest, run-make tests and the run-make-support library) - rust-lang#122605 (rustc-metadata: Store crate name in self-profile of metadata_register_crate) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#121545 - gvozdvmozgu:fix-attribute-validation-associated-items, r=fmease fix attribute validation on associated items in traits rust-lang#121537, fixed attribute validation on associated items in traits

apiraino · 2024-04-02T10:41:32Z

by reading this comment, IIUC this breaking change needs to be mentioned in the release notes

@rustbot label +relnotes

pnkfelix · 2024-04-05T17:45:30Z

I have confirmed locally that cherry-picking this commit to beta happens cleanly, resolves #121537, and presumably also resolves #123287.

Nominating for beta backport.

@rustbot label: beta-nominated

Update: okay I guess i should actually double check that it indeed resolves #123287. Will do.

apiraino · 2024-04-11T14:13:16Z

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

pnkfelix · 2024-04-11T14:19:03Z

Confirmed that backporting fixes the https://github.com/cyphernet-dao/nsh case, which is enough to convince me that the backport will likely resolve them all.

[beta] backports - fix attribute validation on associated items in traits rust-lang#121545 - Only inspect user-written predicates for privacy concerns rust-lang#123377 - Check def id before calling `match_projection_projections` rust-lang#123471 - Restore `pred_known_to_hold_modulo_regions` rust-lang#123578 - Beta revert "Use OS thread name by default" rust-lang#123533 r? cuviper

fix attribute validation on associated items in traits

8b576d5

rustbot assigned estebank Feb 24, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 24, 2024

rustbot assigned fmease and unassigned estebank Feb 24, 2024

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2024

saethlin linked an issue Feb 25, 2024 that may be closed by this pull request

ICE: ast lowering: None #121537

Closed

nnethercote mentioned this pull request Feb 25, 2024

ICE: ast lowering: None #121537

Closed

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 8, 2024

gvozdvmozgu mentioned this pull request Mar 8, 2024

chore: fix must_use attribute syntax wishawa/async_ui#9

Merged

estebank mentioned this pull request Mar 8, 2024

Invalid use of must_use, will cause problems with upcoming Rust stable versions wishawa/async_ui#10

Closed

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2024

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 16, 2024

fmease mentioned this pull request Mar 16, 2024

Rollup of 9 pull requests #122607

Merged

bors merged commit 79c1e58 into rust-lang:master Mar 17, 2024
12 checks passed

rustbot added this to the 1.78.0 milestone Mar 17, 2024

gvozdvmozgu deleted the fix-attribute-validation-associated-items branch March 17, 2024 02:30

fmease mentioned this pull request Mar 20, 2024

expected unsuffixed literal or identifier, found IN_ISDIR #122796

Closed

This was referenced Mar 31, 2024

regression: unwrap on None in ast lowering #123287

Closed

regression: invalid doc attribute #123293

Open

rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 2, 2024

rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 5, 2024

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 11, 2024

cuviper mentioned this pull request Apr 11, 2024

[beta] backports #123801

Merged

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix attribute validation on associated items in traits #121545

fix attribute validation on associated items in traits #121545

gvozdvmozgu commented Feb 24, 2024

rustbot commented Feb 24, 2024

fmease commented Feb 24, 2024

fmease commented Feb 24, 2024 •

edited

bors commented Feb 24, 2024

bors commented Feb 24, 2024

fmease commented Feb 24, 2024

craterbot commented Feb 24, 2024

nnethercote commented Feb 25, 2024

craterbot commented Mar 5, 2024

craterbot commented Mar 8, 2024

fmease commented Mar 11, 2024

fmease commented Mar 16, 2024

fmease commented Mar 16, 2024

bors commented Mar 16, 2024

apiraino commented Apr 2, 2024

pnkfelix commented Apr 5, 2024 •

edited

apiraino commented Apr 11, 2024

pnkfelix commented Apr 11, 2024

fix attribute validation on associated items in traits #121545

fix attribute validation on associated items in traits #121545

Conversation

gvozdvmozgu commented Feb 24, 2024

rustbot commented Feb 24, 2024

fmease commented Feb 24, 2024

fmease commented Feb 24, 2024 • edited

bors commented Feb 24, 2024

bors commented Feb 24, 2024

fmease commented Feb 24, 2024

craterbot commented Feb 24, 2024

nnethercote commented Feb 25, 2024

craterbot commented Mar 5, 2024

craterbot commented Mar 8, 2024

fmease commented Mar 11, 2024

fmease commented Mar 16, 2024

fmease commented Mar 16, 2024

bors commented Mar 16, 2024

apiraino commented Apr 2, 2024

pnkfelix commented Apr 5, 2024 • edited

apiraino commented Apr 11, 2024

pnkfelix commented Apr 11, 2024

fmease commented Feb 24, 2024 •

edited

pnkfelix commented Apr 5, 2024 •

edited