Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump itertools to 0.12 #121584

Merged
merged 2 commits into from
Mar 9, 2024
Merged

bump itertools to 0.12 #121584

merged 2 commits into from
Mar 9, 2024

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Feb 25, 2024 •
edited
Loading

still depend on 0.11 (temporary dupes version):

https://github.com/rust-itertools/itertools/blob/v0.12.1/CHANGELOG.md

removed unused derive_more dep from rustc_middle

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2024

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 25, 2024
@bors
Copy link
Contributor

bors commented Feb 27, 2024

☔ The latest upstream changes (presumably #121677) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 28, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2024

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@bors
Copy link
Contributor

bors commented Mar 5, 2024

☔ The latest upstream changes (presumably #121576) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Mar 7, 2024

☔ The latest upstream changes (presumably #119199) made this pull request unmergeable. Please resolve the merge conflicts.

wesleywiser
wesleywiser approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after rebase

@klensy
bump itertools to 0.12
52501c2 
still depend on 0.11:
* clippy
* rustfmt, sigh
@klensy
remove unused derive_more dep
2de98c8
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2024

📌 Commit 2de98c8 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
@Nadrieril Nadrieril mentioned this pull request Mar 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024
@bors
Auto merge of rust-lang#122256 - Nadrieril:rollup-rc232xh, r=Nadrieril
2d24fe5 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#99153 (Add Read Impl for &Stdin)
 - rust-lang#114655 (Make `impl<Fd: AsFd>` impl take `?Sized`)
 - rust-lang#120504 (Vec::try_with_capacity)
 - rust-lang#121280 (Implement MaybeUninit::fill{,_with,_from})
 - rust-lang#121403 (impl From<TryReserveError> for io::Error)
 - rust-lang#121526 (on the fly type casting for `build.rustc` and `build.cargo`)
 - rust-lang#121584 (bump itertools to 0.12)
 - rust-lang#121711 (Implement junction_point)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bc3bc2b into rust-lang:master Mar 9, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024
@rust-timer
Unrolled build for rust-lang#121584
c50800f 
Rollup merge of rust-lang#121584 - klensy:itertools-up, r=Mark-Simulacrum

bump itertools to 0.12

still depend on 0.11 (temporary dupes version):
* <del>clippy</del>, rust-lang/rust-clippy#12346
* rustfmt, sigh, rust-lang/rustfmt#6093

https://github.com/rust-itertools/itertools/blob/v0.12.1/CHANGELOG.md

removed unused `derive_more` dep from `rustc_middle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@klensy @rustbot @bors @Mark-Simulacrum @wesleywiser