Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use unwrap() in ArrayIntoIter lint when typeck fails #121586

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

gurry
Copy link
Contributor

@gurry gurry commented Feb 25, 2024

Fixes #121532

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 25, 2024
@cjgillot
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 25, 2024

📌 Commit fa75571 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2024
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#119590 (Stabilize `cfg_target_abi`)
 - rust-lang#120805 (make non-PartialEq-typed consts as patterns a hard error)
 - rust-lang#121060 (Add newtypes for bool fields/params/return types)
 - rust-lang#121284 (Add test cases for inlining compiler-private items)
 - rust-lang#121324 (pattern_analysis: factor out unspecialization)
 - rust-lang#121409 (Prevent cycle in implied predicates computation)
 - rust-lang#121513 (Fix sgx unit test compilation)
 - rust-lang#121570 (Make most bootstrap step types !Copy)
 - rust-lang#121586 (Don't use `unwrap()` in `ArrayIntoIter` lint when typeck fails)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a442388 into rust-lang:master Feb 25, 2024
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2024
Rollup merge of rust-lang#121586 - gurry:121532-ice-unwrap-on-none, r=cjgillot

Don't use `unwrap()` in `ArrayIntoIter` lint when typeck fails

Fixes rust-lang#121532
@rustbot rustbot added this to the 1.78.0 milestone Feb 25, 2024
@nnethercote
Copy link
Contributor

Thank you for fixing this, @gurry!

@gurry gurry deleted the 121532-ice-unwrap-on-none branch February 26, 2024 01:59
nnethercote added a commit to nnethercote/rust that referenced this pull request Feb 27, 2024
This undoes the changes from rust-lang#121482 and rust-lang#121586, now that stashed errors
will trigger more early aborts.
nnethercote added a commit to nnethercote/rust that referenced this pull request Feb 27, 2024
This undoes the changes from rust-lang#121482 and rust-lang#121586, now that stashed errors
will trigger more early aborts.
nnethercote added a commit to nnethercote/rust that referenced this pull request Feb 27, 2024
This undoes the changes from rust-lang#121482 and rust-lang#121586, now that stashed errors
will trigger more early aborts.
nnethercote added a commit to nnethercote/rust that referenced this pull request Feb 29, 2024
This undoes the changes from rust-lang#121482 and rust-lang#121586, now that stashed errors
will trigger more early aborts.
nnethercote added a commit to nnethercote/rust that referenced this pull request Mar 1, 2024
This undoes the changes from rust-lang#121482 and rust-lang#121586, now that stashed errors
will trigger more early aborts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: None compiler/rustc_lint/src/array_into_iter.rs
5 participants