New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ?Trait bounds in supertraits and dyn Trait under a feature gate #121676
base: master
Are you sure you want to change the base?
Conversation
rustbot has assigned @petrochenkov. Use r? to explicitly pick a reviewer |
for reference, is there any language team shepherd for all of this default bound experimentation? I only ever see random work and don't remember seeing design documents or anything like that |
This comment has been minimized.
This comment has been minimized.
@Nilstrieb |
allow_maybe_polarity
feature
@rustbot author |
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
@rustbot ready |
Some changes occurred in diagnostic error codes |
Need to link to rust-lang/compiler-team#727 from this PR description. |
d84587a
to
540fde9
Compare
Implementation LGTM, except the commit message needs to be more human oriented. I'm going to pass this to r? @traviscross in cases some additional lang team approval is needed, but otherwise r=me. |
3112584
to
cf7262c
Compare
In the last update |
@rustbot labels +T-lang +I-lang-nominated We'll need to discuss this in a lang meeting for visibility and to ensure this experiment is properly approved, so let's nominate this. https://lang-team.rust-lang.org/how_to/experiment.html @Bryanskiy / @petrochenkov: If you could perhaps write up a summary for the lang team to review as part of this nomination about the nature of this part of the experiment, what the motivation for it is, and how this fits into the larger body of work, that work be helpful. |
Summary:
|
☔ The latest upstream changes (presumably #122132) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
In the last update #120706 (comment) was fixed. |
☔ The latest upstream changes (presumably #122713) made this pull request unmergeable. Please resolve the merge conflicts. |
@Bryanskiy what's the status of this? thanks |
This patch allows
maybe
polarity bounds under a feature gate. The only language change here is that corresponding hard errors are replaced by feature gates. Example:Maybe bounds still don't do anything (except for
Sized
trait), however this patch will allow us to experiment with default auto traits.This is a part of the MCP: Low level components for async drop