Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LitKind::Err for malformed floats #121724

Merged
merged 3 commits into from Feb 29, 2024
Merged

Use LitKind::Err for malformed floats #121724

merged 3 commits into from Feb 29, 2024

Commits on Feb 28, 2024

  1. Use LitKind::Err for floats with empty exponents. 

    This prevents a follow-up type error in a test, which seems fine.
    @nnethercote
    nnethercote committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    951f2d9 View commit details
    Browse the repository at this point in the history

  2. Reformat float-field.rs test. 

    - Put every literal in its own braces, rather than just some of them,
  for maximal error recovery.
- Add a blank line between every case, for readability.
    @nnethercote
    nnethercote committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7976609 View commit details
    Browse the repository at this point in the history

  3. Use LitKind::Err for floats with unsupported bases. 

    This slightly changes error messages in `float-field.rs`, but nothing of
real importance.
    @nnethercote
    nnethercote committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    840c8d3 View commit details
    Browse the repository at this point in the history