`f16` and `f128` step 2: intrinsics #121841

tgross35 · 2024-03-01T09:41:52Z

Continuation of #121728, another portion of #114607.

This PR adds f16 and f128 intrinsics, and hooks them up to both HIR and LLVM. This is all still unexposed to the frontend, which will probably be the next step. Also update itanium mangling per @rcvalle's in https://github.com/rust-lang/rust/pull/121728/files#r1506570300, and fix a typo from step 1.

Once these types are usable in code, I will add the codegen tests from #114607 (codegen is passing on that branch)

This does add more unimplemented!s to Clippy, but I still don't think we can do better until library support is added.

Tracking issue: #116909

r? @compiler-errors
cc @Nilstrieb
@rustbot label +T-compiler +F-f16_and_f128

rustbot · 2024-03-01T09:42:02Z

Some changes occurred in exhaustiveness checking

cc @Nadrieril

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

tgross35 · 2024-03-01T09:44:54Z

Sorry for the noise, accidentally included my commits from #121728. Most of the mentions in that comment are unchanged in this PR.

compiler-errors

One nit, also needs CI to pass. r=me after.

src/tools/clippy/clippy_lints/src/approx_const.rs

compiler-errors · 2024-03-01T18:40:09Z

@bors r+

bors · 2024-03-01T18:40:13Z

📌 Commit f375424 has been approved by compiler-errors

It is now in the queue for this repository.

compiler/rustc_symbol_mangling/src/typeid/typeid_itanium_cxx_abi.rs

compiler-errors · 2024-03-01T18:56:36Z

Actually just fix both of these issues now, there's no rush to get this PR merged.

@bors r-

tgross35 · 2024-03-01T18:59:28Z

Easy enough, fixed both things

compiler-errors · 2024-03-01T19:00:13Z

@bors r+

bors · 2024-03-01T19:00:15Z

📌 Commit 01755e3 has been approved by compiler-errors

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - rust-lang#120761 (Add initial support for DataFlowSanitizer) - rust-lang#121622 (Preserve same vtable pointer when cloning raw waker, to fix Waker::will_wake) - rust-lang#121716 (match lowering: Lower bindings in a predictable order) - rust-lang#121731 (Now that inlining, mir validation and const eval all use reveal-all, we won't be constraining hidden types here anymore) - rust-lang#121841 (`f16` and `f128` step 2: intrinsics) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#121841 - tgross35:f16-f128-step2-intrinsics, r=compiler-errors `f16` and `f128` step 2: intrinsics Continuation of rust-lang#121728, another portion of rust-lang#114607. This PR adds `f16` and `f128` intrinsics, and hooks them up to both HIR and LLVM. This is all still unexposed to the frontend, which will probably be the next step. Also update itanium mangling per `@rcvalle's` in https://github.com/rust-lang/rust/pull/121728/files#r1506570300, and fix a typo from step 1. Once these types are usable in code, I will add the codegen tests from rust-lang#114607 (codegen is passing on that branch) This does add more `unimplemented!`s to Clippy, but I still don't think we can do better until library support is added. r? `@compiler-errors` cc `@Nilstrieb` `@rustbot` label +T-compiler +F-f16_and_f128

…te, r=compiler-errors `f16` and `f128` step 3: compiler support & feature gate Continuation of rust-lang#121841, another portion of rust-lang#114607 This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed). If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes. Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step. Tracking issue: rust-lang#116909 r? `@compiler-errors` cc `@Nilstrieb` `@rustbot` label +F-f16_and_f128

…te, r=compiler-errors `f16` and `f128` step 3: compiler support & feature gate Continuation of rust-lang#121841, another portion of rust-lang#114607 This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed). If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes. Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step. Tracking issue: rust-lang#116909 r? ``@compiler-errors`` cc ``@Nilstrieb`` ``@rustbot`` label +F-f16_and_f128

…te, r=compiler-errors `f16` and `f128` step 3: compiler support & feature gate Continuation of rust-lang#121841, another portion of rust-lang#114607 This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed). If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes. Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step. Tracking issue: rust-lang#116909 r? ```@compiler-errors``` cc ```@Nilstrieb``` ```@rustbot``` label +F-f16_and_f128

…, r=compiler-errors `f16` and `f128` step 2: intrinsics Continuation of rust-lang#121728, another portion of rust-lang#114607. This PR adds `f16` and `f128` intrinsics, and hooks them up to both HIR and LLVM. This is all still unexposed to the frontend, which will probably be the next step. Also update itanium mangling per `@rcvalle's` in https://github.com/rust-lang/rust/pull/121728/files#r1506570300, and fix a typo from step 1. Once these types are usable in code, I will add the codegen tests from rust-lang#114607 (codegen is passing on that branch) This does add more `unimplemented!`s to Clippy, but I still don't think we can do better until library support is added. r? `@compiler-errors` cc `@Nilstrieb` `@rustbot` label +T-compiler +F-f16_and_f128

…, r=compiler-errors,petrochenkov `f16` and `f128` step 3: compiler support & feature gate Continuation of rust-lang#121841, another portion of rust-lang#114607 This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed). If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes. Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step. Tracking issue: rust-lang#116909 r? `@compiler-errors` cc `@Nilstrieb` `@rustbot` label +F-f16_and_f128

…ler-errors,petrochenkov `f16` and `f128` step 3: compiler support & feature gate Continuation of rust-lang/rust#121841, another portion of rust-lang/rust#114607 This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed). If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes. Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step. Tracking issue: rust-lang/rust#116909 r? `@compiler-errors` cc `@Nilstrieb` `@rustbot` label +F-f16_and_f128

rustbot assigned compiler-errors Mar 1, 2024

rustbot added the F-f16_and_f128 `#![feature(f16_and_f128)]` label Mar 1, 2024

tgross35 force-pushed the f16-f128-step2-intrinsics branch from e4816c3 to 5f14869 Compare March 1, 2024 09:42

tgross35 force-pushed the f16-f128-step2-intrinsics branch 2 times, most recently from e39b853 to 78c618e Compare March 1, 2024 09:50

This comment has been minimized.

Sign in to view

compiler-errors requested changes Mar 1, 2024

View reviewed changes

src/tools/clippy/clippy_lints/src/approx_const.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2024

tgross35 force-pushed the f16-f128-step2-intrinsics branch from 78c618e to f375424 Compare March 1, 2024 17:39

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 1, 2024

compiler-errors reviewed Mar 1, 2024

View reviewed changes

src/tools/clippy/clippy_lints/src/approx_const.rs Outdated Show resolved Hide resolved

compiler-errors approved these changes Mar 1, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2024

rcvalle reviewed Mar 1, 2024

View reviewed changes

compiler/rustc_symbol_mangling/src/typeid/typeid_itanium_cxx_abi.rs Show resolved Hide resolved

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 1, 2024

tgross35 added 2 commits March 1, 2024 13:59

Add f16 and f128 LLVM intrinsics

02778b3

Add f16 and f128 to the AST

baba49d

tgross35 added 3 commits March 1, 2024 13:59

Propegate HIR and AST f16 and f128 types to rustdoc

6781801

Propegate HIR and AST f16 and f128 types to clippy

12948a3

Add f16 and f128 intrinsics to HIR

01755e3

tgross35 force-pushed the f16-f128-step2-intrinsics branch from f375424 to 01755e3 Compare March 1, 2024 18:59

compiler-errors approved these changes Mar 1, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 1, 2024

Nadrieril mentioned this pull request Mar 2, 2024

Rollup of 5 pull requests #121914

Merged

tgross35 mentioned this pull request Mar 2, 2024

Tracking Issue for f16 and f128 float types #116909

Open

3 tasks

bors merged commit 4c65eef into rust-lang:master Mar 3, 2024
11 checks passed

rustbot added this to the 1.78.0 milestone Mar 3, 2024

tgross35 deleted the f16-f128-step2-intrinsics branch March 3, 2024 01:28

tgross35 mentioned this pull request Mar 3, 2024

f16 and f128 step 3: compiler support & feature gate #121926

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`f16` and `f128` step 2: intrinsics #121841

`f16` and `f128` step 2: intrinsics #121841

tgross35 commented Mar 1, 2024 •

edited

rustbot commented Mar 1, 2024

tgross35 commented Mar 1, 2024

This comment has been minimized.

compiler-errors left a comment

compiler-errors commented Mar 1, 2024

bors commented Mar 1, 2024

compiler-errors commented Mar 1, 2024

tgross35 commented Mar 1, 2024

compiler-errors commented Mar 1, 2024

bors commented Mar 1, 2024

f16 and f128 step 2: intrinsics #121841

f16 and f128 step 2: intrinsics #121841

Conversation

tgross35 commented Mar 1, 2024 • edited

rustbot commented Mar 1, 2024

tgross35 commented Mar 1, 2024

This comment has been minimized.

compiler-errors left a comment

Choose a reason for hiding this comment

compiler-errors commented Mar 1, 2024

bors commented Mar 1, 2024

compiler-errors commented Mar 1, 2024

tgross35 commented Mar 1, 2024

compiler-errors commented Mar 1, 2024

bors commented Mar 1, 2024

`f16` and `f128` step 2: intrinsics #121841

`f16` and `f128` step 2: intrinsics #121841

tgross35 commented Mar 1, 2024 •

edited