Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing get_name for wasm::thread. #121933

Merged
merged 1 commit into from Mar 3, 2024

Conversation

Iansa9
Copy link
Contributor

@Iansa9 Iansa9 commented Mar 3, 2024

Fixing #121932 by implementing get_name in wasm::thread::Thread.

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nilstrieb (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added O-wasm Target: WASM (WebAssembly), http://webassembly.org/ S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 3, 2024
@Nilstrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 3, 2024

📌 Commit eb5328b has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2024
@ChrisDenton ChrisDenton linked an issue Mar 3, 2024 that may be closed by this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2024
…llaumeGomez

Rollup of 3 pull requests

Successful merges:

 - rust-lang#121917 (Add new `pattern_complexity` attribute to add possibility to limit and check recursion in pattern matching)
 - rust-lang#121933 (Add missing get_name for wasm::thread.)
 - rust-lang#121934 (rustc_log: expose tracing-tree "wraparound" in an env var)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d769ace into rust-lang:master Mar 3, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2024
Rollup merge of rust-lang#121933 - Iansa9:thread-name-wasm-fix, r=Nilstrieb

Add missing get_name for wasm::thread.

Fixing rust-lang#121932 by implementing `get_name` in `wasm::thread::Thread`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-wasm Target: WASM (WebAssembly), http://webassembly.org/ S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function get_name could not be found for wasm::thread::Thread
4 participants