Windows: Implement condvar, mutex and rwlock using futex #121956
Merged
+159
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nilstrieb rustbot has assigned @Nilstrieb. Use r? to explicitly pick a reviewer |
rustbot
added
O-windows
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
ChrisDenton
force-pushed
the
srwlock
branch
2 times, most recently
from
508a095
to
f15b4f7
Compare
ChrisDenton
changed the title
ChrisDenton
force-pushed
the
srwlock
branch
4 times, most recently
from
0aa6381
to
2c7e068
Compare
SkiFire13
reviewed
Mar 4, 2024
|
Incidentally @joboet, I would consider this a successful test case for the sys restructuring. Reusing the futex implementations on Windows was super easy 😁 |
Well, the Windows equivalent: `WaitOnAddress`, `WakeByAddressSingle` and `WakeByAddressAll`.
joboet
approved these changes
Mar 5, 2024
|
Switching sync implementations is a big enough deal that I think this should prefer to avoid being rolled up, if possible. @bors r=joboet rollup=iffy |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
ChrisDenton
added
the
relnotes
|
Finished benchmarking commit (3314d5c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 646.206s -> 646.923s (0.11%) |
RalfJung
added a commit
to RalfJung/miri
that referenced
this pull request
Mar 9, 2024
Since rust-lang/rust#121956 we don't need it any more, and we are generally short on Windows staff so reducing the amount of code we have to test and maintain sounds like a good idea. The InitOnce stuff is still used by `thread_local_key::StaticKey`.
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Mar 12, 2024
windows: remove support for slim rwlock Since rust-lang/rust#121956 we don't need it any more, and we are generally short on Windows staff so reducing the amount of code we have to test and maintain sounds like a good idea. The InitOnce stuff is still used by `thread_local_key::StaticKey` on 64bit windows-gnu.
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Mar 15, 2024
Since rust-lang#121956 we don't need it any more, and we are generally short on Windows staff so reducing the amount of code we have to test and maintain sounds like a good idea. The InitOnce stuff is still used by `thread_local_key::StaticKey`.
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Mar 15, 2024
windows: remove support for slim rwlock Since rust-lang#121956 we don't need it any more, and we are generally short on Windows staff so reducing the amount of code we have to test and maintain sounds like a good idea. The InitOnce stuff is still used by `thread_local_key::StaticKey` on 64bit windows-gnu.
1 task
This was referenced Apr 14, 2024
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
windows: remove support for slim rwlock Since rust-lang/rust#121956 we don't need it any more, and we are generally short on Windows staff so reducing the amount of code we have to test and maintain sounds like a good idea. The InitOnce stuff is still used by `thread_local_key::StaticKey` on 64bit windows-gnu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, the Windows equivalent:
WaitOnAddress,WakeByAddressSingleandWakeByAddressAll.Note that Windows flavoured futexes can be different sizes (1, 2, 4 or 8 bytes). I took advantage of that in the
Muteximplementation.I also edited the Mutex implementation a bit more than necessary. I was having trouble keeping in my head what 0, 1 and 2 meant so I replaced them with consts.
I think we're maybe spinning a bit much.
WaitOnAddressseems to be looping quite a bit too. But for now I've keep the implementations the same. I do wonder if it'd be worth reducing or removing our spinning on Windows.This also adds a new shim to miri, because of course it does.
Fixes #121949