loongarch: add frecipe and relax target feature #122022

heiher · 2024-03-05T12:55:23Z

This PR adds frecipe and relax target features to LoongArch:

frecipe - Support frecipe.{s/d} and frsqrte.{s/d} instructions..
relax - Enable Linker relaxation.

rustbot · 2024-03-05T12:55:31Z

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

petrochenkov · 2024-03-05T13:06:37Z

@bors r+ rollup

bors · 2024-03-05T13:06:40Z

📌 Commit 891e158 has been approved by petrochenkov

It is now in the queue for this repository.

petrochenkov · 2024-03-05T13:36:04Z

@bors r-
r=me when CI is green.

Nilstrieb · 2024-03-05T14:24:55Z

@bors r=petrochenkov

bors · 2024-03-05T14:24:58Z

📌 Commit ec24d75 has been approved by petrochenkov

It is now in the queue for this repository.

Nilstrieb · 2024-03-05T14:26:08Z

tests/ui/check-cfg/well-known-values.stderr

@@ -154,7 +154,7 @@ warning: unexpected `cfg` condition value: `_UNEXPECTED_VALUE`
 LL |     target_feature = "_UNEXPECTED_VALUE",
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
-   = note: expected values for `target_feature` are: `10e60`, `2e3`, `3e3r1`, `3e3r2`, `3e3r3`, `3e7`, `7e10`, `a`, `aclass`, `adx`, `aes`, `altivec`, `alu32`, `atomics`, `avx`, `avx2`, `avx512bf16`, `avx512bitalg`, `avx512bw`, `avx512cd`, `avx512dq`, `avx512er`, `avx512f`, `avx512fp16`, `avx512ifma`, `avx512pf`, `avx512vbmi`, `avx512vbmi2`, `avx512vl`, `avx512vnni`, `avx512vp2intersect`, `avx512vpopcntdq`, `bf16`, `bmi1`, `bmi2`, `bti`, `bulk-memory`, `c`, `cache`, `cmpxchg16b`, `crc`, `crt-static`, `d`, `d32`, `dit`, `doloop`, `dotprod`, `dpb`, `dpb2`, `dsp`, `dsp1e2`, `dspe60`, `e`, `e1`, `e2`, `edsp`, `elrw`, `ermsb`, `exception-handling`, `f`, `f16c`, `f32mm`, `f64mm`, `fast-unaligned-access`, `fcma`, `fdivdu`, `fhm`, `flagm`, `float1e2`, `float1e3`, `float3e4`, `float7e60`, `floate1`, `fma`, `fp-armv8`, `fp16`, `fp64`, `fpuv2_df`, `fpuv2_sf`, `fpuv3_df`, `fpuv3_hf`, `fpuv3_hi`, `fpuv3_sf`, `frintts`, `fxsr`, `gfni`, `hard-float`, `hard-float-abi`, `hard-tp`, `high-registers`, `hvx`, `hvx-length128b`, `hwdiv`, `i8mm`, `jsconv`, `lahfsahf`, `lasx`, `lbt`, `lor`, `lse`, `lsx`, `lvz`, `lzcnt`, `m`, `mclass`, `movbe`, `mp`, `mp1e2`, `msa`, `mte`, `multivalue`, `mutable-globals`, `neon`, `nontrapping-fptoint`, `nvic`, `paca`, `pacg`, `pan`, `pclmulqdq`, `pmuv3`, `popcnt`, `power10-vector`, `power8-altivec`, `power8-vector`, `power9-altivec`, `power9-vector`, `prfchw`, `rand`, `ras`, `rclass`, `rcpc`, `rcpc2`, `rdm`, `rdrand`, `rdseed`, `reference-types`, `relax`, `relaxed-simd`, `rtm`, `sb`, `sha`, `sha2`, `sha3`, `sign-ext`, `simd128`, `sm4`, `spe`, `ssbs`, `sse`, `sse2`, `sse3`, `sse4.1`, `sse4.2`, `sse4a`, `ssse3`, `sve`, `sve2`, `sve2-aes`, `sve2-bitperm`, `sve2-sha3`, `sve2-sm4`, `tbm`, `thumb-mode`, `thumb2`, `tme`, `trust`, `trustzone`, `ual`, `v`, `v5te`, `v6`, `v6k`, `v6t2`, `v7`, `v8`, `v8.1a`, `v8.2a`, `v8.3a`, `v8.4a`, `v8.5a`, `v8.6a`, `v8.7a`, `vaes`, `vdsp2e60f`, `vdspv1`, `vdspv2`, `vfp2`, `vfp3`, `vfp4`, `vh`, `virt`, `virtualization`, `vpclmulqdq`, `vsx`, `xsave`, `xsavec`, `xsaveopt`, `xsaves`, `zba`, `zbb`, `zbc`, `zbkb`, `zbkc`, `zbkx`, `zbs`, `zdinx`, `zfh`, `zfhmin`, `zfinx`, `zhinx`, `zhinxmin`, `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`


@Urgau I've seen this test show up a bunch of times now and every time I think that it's pretty useless to just spam all the values here, do you think it would make sense to abbreviate it and only show a few?

Yes, see #121202.

But also no, not for this test since it's an anti-regression test. We want to make sure that the list doesn't change by accident since with check-cfg any unexpected cfg will report a warning and we should avoid false-positive.

…chenkov loongarch: add frecipe and relax target feature This PR adds `frecipe` and `relax` target features to LoongArch: * frecipe - Support frecipe.{s/d} and frsqrte.{s/d} instructions.. * relax - Enable Linker relaxation.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121065 (Add basic i18n guidance for `Display`) - rust-lang#121301 (errors: share `SilentEmitter` between rustc and rustfmt) - rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check) - rust-lang#121829 (Dummy tweaks (attempt 2)) - rust-lang#121857 (Implement async closure signature deduction) - rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now) - rust-lang#121905 (Add a `description` field to target definitions) - rust-lang#122022 (loongarch: add frecipe and relax target feature) - rust-lang#122028 (Remove some dead code) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-03-05T18:48:08Z

@bors r-
#122033 (comment)

heiher · 2024-03-06T10:58:46Z

@rustbot ready

x86_64-gnu and x86_64-gnu-llvm-17 are now passed.

petrochenkov · 2024-03-06T11:23:52Z

@bors r+

bors · 2024-03-06T11:23:54Z

📌 Commit e81df3f has been approved by petrochenkov

It is now in the queue for this repository.

…chenkov loongarch: add frecipe and relax target feature This PR adds `frecipe` and `relax` target features to LoongArch: * frecipe - Support frecipe.{s/d} and frsqrte.{s/d} instructions.. * relax - Enable Linker relaxation.

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#121958 (Fix redundant import errors for preload extern crate) - rust-lang#121976 (Add an option to have an external download/bootstrap cache) - rust-lang#122022 (loongarch: add frecipe and relax target feature) - rust-lang#122026 (Do not try to format removed files) - rust-lang#122027 (Uplift some feeding out of `associated_type_for_impl_trait_in_impl` and into queries) - rust-lang#122063 (Make the lowering of `thir::ExprKind::If` easier to follow) - rust-lang#122066 (Add proper cfgs for struct HirIdValidator used only with debug-assert) - rust-lang#122074 (Add missing PartialOrd trait implementation doc for array) - rust-lang#122082 (remove outdated fixme comment) - rust-lang#122091 (Note why we're using a new thread in `test_get_os_named_thread`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121958 (Fix redundant import errors for preload extern crate) - rust-lang#121976 (Add an option to have an external download/bootstrap cache) - rust-lang#122022 (loongarch: add frecipe and relax target feature) - rust-lang#122026 (Do not try to format removed files) - rust-lang#122027 (Uplift some feeding out of `associated_type_for_impl_trait_in_impl` and into queries) - rust-lang#122063 (Make the lowering of `thir::ExprKind::If` easier to follow) - rust-lang#122074 (Add missing PartialOrd trait implementation doc for array) - rust-lang#122082 (remove outdated fixme comment) - rust-lang#122091 (Note why we're using a new thread in `test_get_os_named_thread`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#122022 - heiher:loongarch-features, r=petrochenkov loongarch: add frecipe and relax target feature This PR adds `frecipe` and `relax` target features to LoongArch: * frecipe - Support frecipe.{s/d} and frsqrte.{s/d} instructions.. * relax - Enable Linker relaxation.

rustbot assigned petrochenkov Mar 5, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 5, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2024

This comment has been minimized.

Sign in to view

heiher force-pushed the loongarch-features branch from 891e158 to ec24d75 Compare March 5, 2024 13:19

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2024

Nilstrieb reviewed Mar 5, 2024

View reviewed changes

matthiaskrgr mentioned this pull request Mar 5, 2024

Rollup of 10 pull requests #122030

Closed

matthiaskrgr mentioned this pull request Mar 5, 2024

Rollup of 9 pull requests #122033

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2024

loongarch: add frecipe and relax target feature

e81df3f

heiher force-pushed the loongarch-features branch from ec24d75 to e81df3f Compare March 6, 2024 09:50

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 6, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2024

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 10 pull requests #122096

Closed

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 9 pull requests #122113

Merged

bors merged commit daf89d0 into rust-lang:master Mar 7, 2024
11 checks passed

rustbot added this to the 1.78.0 milestone Mar 7, 2024

heiher deleted the loongarch-features branch March 11, 2024 02:44

xen0n mentioned this pull request Mar 11, 2024

Content suggestion for This Week in LoongArch newsletter / 《每周一龙》新闻线索信箱 loongson-community/areweloongyet#16

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

loongarch: add frecipe and relax target feature #122022

loongarch: add frecipe and relax target feature #122022

heiher commented Mar 5, 2024

rustbot commented Mar 5, 2024

petrochenkov commented Mar 5, 2024

bors commented Mar 5, 2024

This comment has been minimized.

petrochenkov commented Mar 5, 2024

Nilstrieb commented Mar 5, 2024

bors commented Mar 5, 2024

Nilstrieb Mar 5, 2024

Urgau Mar 5, 2024 •

edited

matthiaskrgr commented Mar 5, 2024

heiher commented Mar 6, 2024

petrochenkov commented Mar 6, 2024

bors commented Mar 6, 2024

loongarch: add frecipe and relax target feature #122022

loongarch: add frecipe and relax target feature #122022

Conversation

heiher commented Mar 5, 2024

rustbot commented Mar 5, 2024

petrochenkov commented Mar 5, 2024

bors commented Mar 5, 2024

This comment has been minimized.

petrochenkov commented Mar 5, 2024

Nilstrieb commented Mar 5, 2024

bors commented Mar 5, 2024

Nilstrieb Mar 5, 2024

Choose a reason for hiding this comment

Urgau Mar 5, 2024 • edited

Choose a reason for hiding this comment

matthiaskrgr commented Mar 5, 2024

heiher commented Mar 6, 2024

petrochenkov commented Mar 6, 2024

bors commented Mar 6, 2024

Urgau Mar 5, 2024 •

edited