Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the lowering of thir::ExprKind::If easier to follow #122063

Merged
merged 3 commits into from Mar 7, 2024
Merged

Make the lowering of thir::ExprKind::If easier to follow #122063

merged 3 commits into from Mar 7, 2024

Commits on Mar 6, 2024

  1. Clarify how lowering if produces then/else blocks 

    This makes it easier to see that the call to `in_scope` returns both the then
block and the else block. The rather confusing `unpack!` step is confined to
its own separate line.

(This patch reindents several lines, so using "ignore whitespace" is
recommended in order to focus on the actual changes.)
    @Zalathar
    Zalathar committed Mar 6, 2024
    Copy the full SHA
    7396fd1 View commit details
    Browse the repository at this point in the history

  2. Clarify lowering the else arm into the else block

    @Zalathar
    Zalathar committed Mar 6, 2024
    Copy the full SHA
    3402f39 View commit details
    Browse the repository at this point in the history

  3. Additional comments for lowering if

    @Zalathar
    Zalathar committed Mar 6, 2024
    Copy the full SHA
    250e697 View commit details
    Browse the repository at this point in the history