Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade const eval dangling ptr in final to future incompat lint #122204

Merged
merged 9 commits into from Mar 14, 2024
Merged

Downgrade const eval dangling ptr in final to future incompat lint #122204

merged 9 commits into from Mar 14, 2024

Commits on Mar 13, 2024

  1. downgrade mutable-ptr-in-final-value from hard-error to future-incomp… 

    …at lint to address issue 121610.
    @pnkfelix
    pnkfelix committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a8549b4 View commit details
    Browse the repository at this point in the history

  2. regression test from 121610.

    @pnkfelix
    pnkfelix committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f86b46a View commit details
    Browse the repository at this point in the history

  3. Added deny(const_eval_mutable_ptr_in_final_value) attribute to all … 

    …tests that were expecting the hard error for it.

I attempted to do this in a manner that preserved the line numbers to reduce the
review effort on the resulting diff, but we still have to deal with the
ramifications of how a future-incompat lint behaves compared to a hard-error (in
terms of its impact on the diagnostic output).
    @pnkfelix
    pnkfelix committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1c3424b View commit details
    Browse the repository at this point in the history

  4. Added an "Explanation" header and expanded that section for the newly… 

    … added lint.
    @pnkfelix
    pnkfelix committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6ca46da View commit details
    Browse the repository at this point in the history

  5. Updated the test to include more output normalization.

    @pnkfelix
    pnkfelix committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    354c41e View commit details
    Browse the repository at this point in the history

  6. Add produces as tidy requires

    @wesleywiser @pnkfelix
    wesleywiser authored and pnkfelix committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ae374cf View commit details
    Browse the repository at this point in the history

  7. Rebase. Update expected output to match current output.

    @pnkfelix
    pnkfelix committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1ea091a View commit details
    Browse the repository at this point in the history

  8. placate tidy.

    @pnkfelix
    pnkfelix committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    9c33cc6 View commit details
    Browse the repository at this point in the history

  9. include 32-bit variant for updated test of miri diagnostics.

    @pnkfelix
    pnkfelix committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    8f45a9e View commit details
    Browse the repository at this point in the history