Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less symbol interner locks #122530

Merged
merged 1 commit into from
Mar 15, 2024
Merged

less symbol interner locks #122530

merged 1 commit into from
Mar 15, 2024

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Mar 15, 2024 •
edited
Loading

This reduces instructions under 1% (in rustdoc run), but essentially free.

@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2024

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 15, 2024
klensy
klensy commented Mar 15, 2024
View reviewed changes
src/librustdoc/html/render/mod.rs
trait_
.items
.iter()
.find(|item| item.name.map(|n| n == *name).unwrap_or(false))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equal symbols <==> equal strings.

@Kobzol
Copy link
Contributor

Kobzol commented Mar 15, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2024
@bors
Auto merge of rust-lang#122530 - klensy:as_str, r=<try>
cd7a399 
less symbol interner locks

This reduces instructions under 1% (in rustdoc run), but essentially free.
@bors
Copy link
Contributor

bors commented Mar 15, 2024

⌛ Trying commit 7ea4f35 with merge cd7a399...

@klensy
Copy link
Contributor Author

klensy commented Mar 15, 2024

@bors try @rust-timer queue

This is well under 1%, so this can catch regressions only :-)

@rust-timer

This comment has been minimized.

Sign in to view
@Kobzol
Copy link
Contributor

Kobzol commented Mar 15, 2024

If it results in instruction count changes, then it could be visible. Even if not, we can indeed check if it didn't produce a regression :) The perf. queue is empty anyway.

@bors
Copy link
Contributor

bors commented Mar 15, 2024

☀️ Try build successful - checks-actions
Build commit: cd7a399 (cd7a3990d6e6feb4905cb13a66fbbde81e3ad88d)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cd7a399): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.8% [2.8%, 2.8%] 1
Regressions ❌
(secondary)		 2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.8% [2.8%, 2.8%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.0% [-1.0%, -1.0%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.125s -> 669.129s (0.00%)
Artifact size: 311.46 MiB -> 311.48 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 15, 2024
@fee1-dead
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 15, 2024

📌 Commit 7ea4f35 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 15, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2024
@bors
Auto merge of rust-lang#122555 - GuillaumeGomez:rollup-tr6wu54, r=Gui…
72d7897 
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#114651 (rustdoc: add `--test-builder-wrapper` arg to support wrappers such as RUSTC_WRAPPER when building doctests)
 - rust-lang#122468 (Cleanup `MirBorrowckCtxt::prefixes`)
 - rust-lang#122496 (Greatly reduce GCC build logs)
 - rust-lang#122512 (Cursor.rs documentation fix)
 - rust-lang#122513 (hir: Remove `opt_local_def_id_to_hir_id` and `opt_hir_node_by_def_id`)
 - rust-lang#122530 (less symbol interner locks)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6ec4092 into rust-lang:master Mar 15, 2024
12 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2024
@rust-timer
Unrolled build for rust-lang#122530
ca0c189 
Rollup merge of rust-lang#122530 - klensy:as_str, r=fee1-dead

less symbol interner locks

This reduces instructions under 1% (in rustdoc run), but essentially free.
@rustbot rustbot added this to the 1.78.0 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@klensy @rustbot @Kobzol @rust-timer @bors @fee1-dead