LLVM bitcode linker: use --cfg=parallel_compiler to avoid invalidating the build cache of rustdoc #122558

kjetilkjeka · 2024-03-15T16:40:24Z

rustbot · 2024-03-15T16:40:31Z

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

onur-ozkan · 2024-03-15T19:34:28Z

src/bootstrap/src/core/build_steps/tool.rs

+                    false || builder.build.unstable_features(),
+                    |tools| {
+                        tools.iter().any(|tool| match tool.as_ref() {
+                            "clippy" => "llvm-bitcode-linker" == "clippy-driver",


This was an accident I guess

This is expanded from the macro it previously was generated from. I don't know if it was important for something so I didn't dare to remove it.

Are you saying I should remove it?

It should be indeed removed. "clippy" => "llvm-bitcode-linker" == "clippy-driver" has no purpose. Something like |tools| tools.iter().any(|tool| tool == "llvm-bitcode-linker") should be enough.

I actually read the code now, and it is indeed meaningless. Should be fixed now

kjetilkjeka · 2024-03-16T14:18:29Z

@rustbot ready

onur-ozkan · 2024-03-16T14:49:20Z

@bors r+

bors · 2024-03-16T14:49:23Z

📌 Commit 3c34cbe has been approved by onur-ozkan

It is now in the queue for this repository.

…_trigger_rebuild, r=onur-ozkan LLVM bitcode linker: use --cfg=parallel_compiler to avoid invalidating the build cache of rustdoc fixes rust-lang#122491 `@rustbot` ready

matthiaskrgr · 2024-03-17T07:23:03Z

@bors rollup=iffy

onur-ozkan · 2024-03-17T07:26:20Z

src/bootstrap/src/core/build_steps/tool.rs

+            let bindir = builder.sysroot(self.compiler).join("bin");
+            t!(fs::create_dir_all(&bindir));
+            let bin_destination = bindir.join(exe(bin_name, self.compiler.host));
+            builder.copy(&tool_out, &bin_destination);


This function no longer exists (since #122590) in the upstream. Can you rebase the PR and fix that?

onur-ozkan · 2024-03-17T07:26:27Z

@bors r-

…he cache of rustdoc

kjetilkjeka · 2024-03-17T23:45:54Z

@rustbot ready

onur-ozkan · 2024-03-18T06:39:35Z

@bors r+

bors · 2024-03-18T06:39:37Z

📌 Commit 7bdd63d has been approved by onur-ozkan

It is now in the queue for this repository.

bors · 2024-03-18T08:21:23Z

⌛ Testing commit 7bdd63d with merge d74fac6...

…rigger_rebuild, r=onur-ozkan LLVM bitcode linker: use --cfg=parallel_compiler to avoid invalidating the build cache of rustdoc fixes rust-lang#122491 `@rustbot` ready

rust-log-analyzer · 2024-03-18T09:19:19Z

The job aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2024-03-18T09:19:50Z

💔 Test failed - checks-actions

onur-ozkan · 2024-03-18T09:24:09Z

@bors retry

bors · 2024-03-18T09:48:43Z

⌛ Testing commit 7bdd63d with merge 13abc0a...

bors · 2024-03-18T12:06:32Z

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 13abc0a to master...

rust-log-analyzer · 2024-03-18T12:10:50Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[endgroup]
Starting download for Cargo-lock
Directory structure has been setup for the artifact
Total number of files that will be downloaded: 1
Artifact Cargo-lock was downloaded to /home/runner/work/rust/rust
##[group]Run actions/download-artifact@v3
with:
  name: cargo-updates
---
##[endgroup]
Starting download for cargo-updates
Directory structure has been setup for the artifact
Total number of files that will be downloaded: 1
Skipping download validation.
Artifact cargo-updates was downloaded to /home/runner/work/rust/rust
##[group]Run echo "${COMMIT_MESSAGE}" > commit.txt
echo "${COMMIT_MESSAGE}" > commit.txt
echo "${COMMIT_MESSAGE}" > commit.txt
cat cargo_update.log >> commit.txt

echo "${PR_MESSAGE}" > body.md
echo '```txt' >> body.md
cat cargo_update.log >> body.md
echo '```' >> body.md
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  RUSTC_BOOTSTRAP: 1
  PR_TITLE: Weekly `cargo update`
  PR_MESSAGE: Automation to keep dependencies in `Cargo.lock` current.
following is the output from `cargo update`:
  COMMIT_MESSAGE: cargo update 
##[endgroup]
##[group]Run git config user.name github-actions
git config user.name github-actions
git config user.email github-actions@github.com
git switch --force-create cargo_update
git add ./Cargo.lock
git commit --no-verify --file=commit.txt
---
##[endgroup]
Switched to a new branch 'cargo_update'
On branch cargo_update
Untracked files:
  (use "git add <file>..." to include in what will be committed)
 body.md
 commit.txt


nothing added to commit but untracked files present (use "git add" to track)
##[error]Process completed with exit code 1.

rust-timer · 2024-03-18T13:20:50Z

Finished benchmarking commit (13abc0a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.3%, 2.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.94s -> 668.532s (-0.06%)
Artifact size: 312.77 MiB -> 312.74 MiB (-0.01%)

rustbot assigned onur-ozkan Mar 15, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 15, 2024

onur-ozkan reviewed Mar 15, 2024

View reviewed changes

clubby789 changed the title ~~LLVM bitcode linker: use --cfg=parallell_compiler to avoid invalidating the build cache of rustdoc~~ LLVM bitcode linker: use --cfg=parallel_compiler to avoid invalidating the build cache of rustdoc Mar 15, 2024

onur-ozkan added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2024

kjetilkjeka force-pushed the llvm_bitcode_linker_no_trigger_rebuild branch from c64dea9 to 3c34cbe Compare March 16, 2024 14:14

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 16, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2024

matthiaskrgr mentioned this pull request Mar 17, 2024

Rollup of 6 pull requests #122624

Closed

onur-ozkan reviewed Mar 17, 2024

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 17, 2024

LLVM bitcode linker: use --cfg=parallell_compiler to avoid trashing t…

7bdd63d

…he cache of rustdoc

kjetilkjeka force-pushed the llvm_bitcode_linker_no_trigger_rebuild branch from 3c34cbe to 7bdd63d Compare March 17, 2024 22:21

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 17, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 18, 2024

bors merged commit 13abc0a into rust-lang:master Mar 18, 2024
12 checks passed

rustbot added this to the 1.79.0 milestone Mar 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LLVM bitcode linker: use --cfg=parallel_compiler to avoid invalidating the build cache of rustdoc #122558

LLVM bitcode linker: use --cfg=parallel_compiler to avoid invalidating the build cache of rustdoc #122558

kjetilkjeka commented Mar 15, 2024

rustbot commented Mar 15, 2024

onur-ozkan Mar 15, 2024

kjetilkjeka Mar 15, 2024

onur-ozkan Mar 15, 2024

kjetilkjeka Mar 16, 2024

kjetilkjeka commented Mar 16, 2024

onur-ozkan commented Mar 16, 2024

bors commented Mar 16, 2024

matthiaskrgr commented Mar 17, 2024

onur-ozkan Mar 17, 2024

onur-ozkan commented Mar 17, 2024

kjetilkjeka commented Mar 17, 2024

onur-ozkan commented Mar 18, 2024

bors commented Mar 18, 2024

bors commented Mar 18, 2024

rust-log-analyzer commented Mar 18, 2024

bors commented Mar 18, 2024

onur-ozkan commented Mar 18, 2024

bors commented Mar 18, 2024

bors commented Mar 18, 2024

rust-log-analyzer commented Mar 18, 2024

rust-timer commented Mar 18, 2024

LLVM bitcode linker: use --cfg=parallel_compiler to avoid invalidating the build cache of rustdoc #122558

LLVM bitcode linker: use --cfg=parallel_compiler to avoid invalidating the build cache of rustdoc #122558

Conversation

kjetilkjeka commented Mar 15, 2024

rustbot commented Mar 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kjetilkjeka commented Mar 16, 2024

onur-ozkan commented Mar 16, 2024

bors commented Mar 16, 2024

matthiaskrgr commented Mar 17, 2024

Choose a reason for hiding this comment

onur-ozkan commented Mar 17, 2024

kjetilkjeka commented Mar 17, 2024

onur-ozkan commented Mar 18, 2024

bors commented Mar 18, 2024

bors commented Mar 18, 2024

rust-log-analyzer commented Mar 18, 2024

bors commented Mar 18, 2024

onur-ozkan commented Mar 18, 2024

bors commented Mar 18, 2024

bors commented Mar 18, 2024

rust-log-analyzer commented Mar 18, 2024

rust-timer commented Mar 18, 2024

Overall result: no relevant changes - no action needed