Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where option_env! would return None when env var is present but not valid Unicode #122670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug where option_env! would return None when env var is present but not valid Unicode #122670

wants to merge 1 commit into from
+72 −23

Conversation

beetrees
Copy link
Contributor

Built on top of #122663.

See #122669 for details (this is an implementation of option 1 from that bug report).

@rustbot
Copy link
Collaborator

rustbot commented Mar 18, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 18, 2024

Some changes occurred in run-make tests.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

@beetrees beetrees marked this pull request as draft March 18, 2024 01:12
@beetrees beetrees mentioned this pull request Mar 18, 2024
Open
@lcnr lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2024
@bors
Copy link
Contributor

bors commented Mar 27, 2024

☔ The latest upstream changes (presumably #122460) made this pull request unmergeable. Please resolve the merge conflicts.

@beetrees beetrees force-pushed the non-unicode-option-env-error branch from ce38fc0 to 0a3363b Compare April 1, 2024 16:29
@beetrees
Copy link
Contributor Author

beetrees commented Apr 1, 2024

Now that #122663 has been merged, this is waiting on the outcome of #122669.

@beetrees beetrees marked this pull request as ready for review April 21, 2024 16:43
@beetrees
Copy link
Contributor Author

Not sure what the right tags for this PR are: the implementation is ready for review but I believe it needs to wait for a decision from libs-api on #122669 before it can be merged, so maybe S-blocked or S-waiting-on-team?

@ChrisDenton ChrisDenton added the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label Apr 21, 2024
@bors
Copy link
Contributor

bors commented Apr 27, 2024

☔ The latest upstream changes (presumably #124424) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@beetrees @rustbot @bors @ChrisDenton @lcnr @Dylan-DPC