-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where option_env!
would return None
when env var is present but not valid Unicode
#122670
base: master
Are you sure you want to change the base?
Conversation
☔ The latest upstream changes (presumably #122460) made this pull request unmergeable. Please resolve the merge conflicts. |
…nt but not valid Unicode
ce38fc0
to
0a3363b
Compare
Not sure what the right tags for this PR are: the implementation is ready for review but I believe it needs to wait for a decision from libs-api on #122669 before it can be merged, so maybe S-blocked or S-waiting-on-team? |
☔ The latest upstream changes (presumably #124424) made this pull request unmergeable. Please resolve the merge conflicts. |
This doesn't seem like it needs an ACP (and I haven't seen one linked anyway), but libs-api probably needs to take a look and make a decision before this gets compiler review. @rustbot label -T-libs +T-libs-api -S-waiting-on-ACP +S-waiting-on-review |
Built on top of #122663.
See #122669 for details (this is an implementation of option 1 from that bug report).