Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conditionally ignore fatal diagnostic in the SilentEmitter #122737

Merged
merged 1 commit into from Mar 24, 2024
Merged

conditionally ignore fatal diagnostic in the SilentEmitter #122737

merged 1 commit into from Mar 24, 2024

Commits on Mar 19, 2024

  1. conditionally ignore fatal diagnostic in the SilentEmitter 

    This change is primarily meant to allow rustfmt to ignore all
diagnostics when using the `SilentEmitter`. Back in PR 121301 the
`SilentEmitter` was shared between rustc and rustfmt. This changed
rustfmt's behavior from ignoring all diagnostic to emitting fatal
diagnostics.

These changes allow rustfmt to maintain it's previous behaviour when
using the SilentEmitter, while allowing rustc code to still emit fatal
diagnostics.
    @ytmimi
    ytmimi committed Mar 19, 2024
    Copy the full SHA
    d49d136 View commit details
    Browse the repository at this point in the history