Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor makefiles to be more flexible producing binary install images #12284

Merged
merged 6 commits into from
Feb 17, 2014

Conversation

brson
Copy link
Contributor

@brson brson commented Feb 15, 2014

Work toward #9876.

This adds prepare.mk, which is simply a more heavily-parameterized install.mk, then uses prepare to implement both install and the windows installer (dist). Smoke tested on both Linux and Windows.

This is a slightly more generic rewrite of install.mk. Currently
used for nothing, but we'll base all the binary distributables off it.
Fallout from moving doc/ to src/doc
@alexcrichton
Copy link
Member

You may want to make sure that make uninstall works as well, and I'd just diff an install previously with a new install just to make sure nothing was forgotten.

@brson
Copy link
Contributor Author

brson commented Feb 15, 2014

I just realized this will run as root during installation from source. Think about that.

@brson
Copy link
Contributor Author

brson commented Feb 15, 2014

Well, we would probably end up not having install be based directly on prepare once the rest of the binary installer stuff is in place, which install would use for consistency.

@brson
Copy link
Contributor Author

brson commented Feb 15, 2014

I want to just rewrite this in Rust.

@alexcrichton
Copy link
Member

I just realized this will run as root during installation from source.

Why is that? Is that because of the make && sudo make install pattern?

I want to just rewrite this in Rust.

I would not be opposed, but if it works for now, perhaps we can keep it?

@brson
Copy link
Contributor Author

brson commented Feb 16, 2014

Yes because of sudo make install.

@brson
Copy link
Contributor Author

brson commented Feb 16, 2014

I've done testing in a number of multi-target/multi-host configs now. Think this is working.

@brson
Copy link
Contributor Author

brson commented Feb 16, 2014

Oh, this still doesn't support $(DESTDIR). Not ready.

@brson
Copy link
Contributor Author

brson commented Feb 17, 2014

$(DESTDIR) works now. This is ready.

bors added a commit that referenced this pull request Feb 17, 2014
Work toward #9876.

This adds `prepare.mk`, which is simply a more heavily-parameterized `install.mk`, then uses `prepare` to implement both `install` and the windows installer (`dist`). Smoke tested on both Linux and Windows.
@bors bors closed this Feb 17, 2014
@bors bors merged commit 2b64cb2 into rust-lang:master Feb 17, 2014
@emberian emberian mentioned this pull request Feb 17, 2014
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
internal: Cleanup lifetime elision hints
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 27, 2024
Fix ICE in `upper_case_acronyms`

fixes rust-lang#12284

The logic has been rewritten to avoid allocations. The old version allocated multiple vecs and strings for each identifier. The new logic allocates a single string only when the lint triggers.

This also no longer lints on strings which don't start with an uppercase letter (e.g. `something_FOO`).

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants