simplify_branches: add comment #122996
Merged
simplify_branches: add comment #122996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
I think it's because we modified the CFG. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#122766 (store segment and module in `UnresolvedImportError`) - rust-lang#122996 (simplify_branches: add comment) - rust-lang#123047 (triagebot: Add notification of 2024 issues) - rust-lang#123066 (CFI: (actually) check that methods are object-safe before projecting their receivers to `dyn Trait` in CFI) - rust-lang#123067 (match lowering: consistently merge simple or-patterns) - rust-lang#123069 (Revert `cargo update` changes and bump `download-artifact` to v4) - rust-lang#123070 (Add my former address to .mailmap) - rust-lang#123086 (Fix doc link to BufWriter in std::fs::File documentation) - rust-lang#123090 (Remove `CacheSelector` trait now that we can use GATs) - rust-lang#123091 (Delegation: fix ICE on wrong `self` resolution) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2024
Rollup merge of rust-lang#122996 - RalfJung:simplify_branches, r=cjgillot simplify_branches: add comment I am not quite sure why this simplification is done here and not in InstSimplify but 🤷 r? `@cjgillot`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not quite sure why this simplification is done here and not in InstSimplify but 🤷
r? @cjgillot