std::net: adding tcp_syncnt feature for Linux/Android. #123111
+60
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
rustbot
added
O-unix
juntyr
reviewed
Mar 26, 2024
Comment on lines
107
to
122
| /// The maximum valid value is 255. | ||
| /// | ||
| /// See [`man 7 tcp`](https://man7.org/linux/man-pages/man7/tcp.7.html) | ||
| /// | ||
| /// # Examples | ||
| /// | ||
| /// ```no_run | ||
| /// #![feature(tcp_syncnt)] | ||
| /// use std::net::TcpStream; | ||
| /// use std::os::linux::net::TcpStreamExt; | ||
| /// | ||
| /// let stream = TcpStream::connect("127.0.0.1:8080") | ||
| /// .expect("Couldn't connect to the server..."); | ||
| /// stream.set_syncnt(3).expect("set_setcnt call failed"); | ||
| #[unstable(feature = "tcp_syncnt", issue = "123112")] | ||
| fn set_syncnt(&self, count: u32) -> io::Result<()>; |
There was a problem hiding this comment.
Just out of curiosity - could the count parameter just be a u8 since the docs state a maximum valid value of 255 (or is it expected that this maximum might rise in the future)?
There was a problem hiding this comment.
it definitively can be u8.
to control the number of client's attempts to establish a connection.
ChrisDenton
added
T-libs-api
|
The implementation looks fine but adding APIs should probably have some libs-api oversight. So choosing a libs-api member at random... r? joshtriplett |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to control the number of client's attempts to establish a connection.