Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add/sub methods that only panic with debug assertions to rustc #123175

Merged
merged 1 commit into from Apr 13, 2024

Conversation

Nilstrieb
Copy link
Member

@Nilstrieb Nilstrieb commented Mar 28, 2024

This mitigates the perf impact of enabling overflow checks on rustc. The change to use overflow checks will be done in a later PR.

For rust-lang/compiler-team#724, based on data gathered in #119440.

@rustbot
Copy link
Collaborator

rustbot commented Mar 28, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 28, 2024
@Nilstrieb
Copy link
Member Author

@wesleywiser o/

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

Could you fix the PR description as well? I don't think #724 is right 😄

compiler/rustc_data_structures/src/sip128.rs Show resolved Hide resolved
compiler/rustc_serialize/src/leb128.rs Outdated Show resolved Hide resolved
compiler/rustc_serialize/src/opaque.rs Outdated Show resolved Hide resolved
compiler/rustc_span/src/span_encoding.rs Show resolved Hide resolved
@wesleywiser
Copy link
Member

@bors rollup=never

Perf sensitive

This mitigates the perf impact of enabling overflow checks on rustc.
The change to use overflow checks will be done in a later PR.
@Nilstrieb
Copy link
Member Author

I don't think this should be performance sensitive, but you never know what happens
@bors r=wesleywiser

@bors
Copy link
Contributor

bors commented Apr 13, 2024

📌 Commit 5039160 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2024
@bors
Copy link
Contributor

bors commented Apr 13, 2024

⌛ Testing commit 5039160 with merge af6a161...

@bors
Copy link
Contributor

bors commented Apr 13, 2024

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing af6a161 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 13, 2024
@bors bors merged commit af6a161 into rust-lang:master Apr 13, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 13, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (af6a161): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.8% [-3.8%, -3.8%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.7% [1.7%, 1.7%] 1
Regressions ❌
(secondary)
3.0% [2.0%, 3.6%] 9
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.6% [-1.6%, -1.6%] 1
All ❌✅ (primary) 1.7% [1.7%, 1.7%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.445s -> 676.973s (-0.07%)
Artifact size: 315.99 MiB -> 316.12 MiB (0.04%)

@Nilstrieb Nilstrieb deleted the debug-strict-overflow branch April 13, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants