rustdoc: point at span in include_str!-ed md file
#123204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/include-str-span
branch
from
540785e
to
1b73c7d
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/include-str-span
branch
from
a21216f
to
534e900
Compare
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/include-str-span
branch
from
534e900
to
1c41dd6
Compare
GuillaumeGomez
approved these changes
Apr 2, 2024
|
r? compiler |
pnkfelix
reviewed
Apr 12, 2024
| | | ||
| LL | let b: &[u8] = include_str!("file.txt"); | ||
| | ----- ^^^^^^^^^^^^^^^^^^^^^^^^ expected `&[u8]`, found `&str` | ||
| | ----- ------------------------ in this macro invocation |
There was a problem hiding this comment.
I was a little nervous when I saw this that we were no longer printing the expected+actual types in the new output, but I expanded the diff and now see that the info is still present via a note that was in the previous output. Its a little more awkward to force people to look at the note to see this info, but its acceptable.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123204 (rustdoc: point at span in `include_str!`-ed md file) - rust-lang#123223 (Fix invalid silencing of parsing error) - rust-lang#123249 (do not add prolog for variadic naked functions) - rust-lang#123825 (Call the panic hook for non-unwind panics in proc-macros) - rust-lang#123833 (Update stdarch submodule) - rust-lang#123841 (Improve diagnostic by suggesting to remove visibility qualifier) - rust-lang#123849 (Update E0384.md) - rust-lang#123852 (fix typo in library/std/src/lib.rs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
Rollup merge of rust-lang#123204 - notriddle:notriddle/include-str-span, r=pnkfelix rustdoc: point at span in `include_str!`-ed md file Fixes rust-lang#118549
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 18, 2024
…an, r=pnkfelix rustdoc: point at span in `include_str!`-ed md file Fixes rust-lang#118549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118549