Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling tests/run-make/compiler-builtins for sgx target(x86_64-fortanix-unknown-sgx) #123405

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NirjharRoyiitk
Copy link

Disabling tests/run-make/compiler-builtins for sgx target(x86_64-fortanix-unknown-sgx).

@rustbot
Copy link
Collaborator

rustbot commented Apr 3, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot
Copy link
Collaborator

rustbot commented Apr 3, 2024

Some changes occurred in run-make tests.

cc @jieyouxu

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 3, 2024
@NirjharRoyiitk
Copy link
Author

cc: @raoulstrackx @jethrogb

//@ ignore-wasm
//@ ignore-nvptx64
//@ ignore-sgx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason why this can't run successfully for the sgx target. Our CI fails on the rustc command itself (line 69). The rest of the test looks at the generated archive, but this runs on the Linux platform, not sgx. So accessing files and directories are totally fine. Yes eventually enclaves are generated for the sgx plaform where it's too late to link in more binaries, but that doesn't happen at the rustc level but later on.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants