New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling tests/run-make/compiler-builtins for sgx target(x86_64-fortanix-unknown-sgx) #123405
base: master
Are you sure you want to change the base?
Disabling tests/run-make/compiler-builtins for sgx target(x86_64-fortanix-unknown-sgx) #123405
Conversation
…tanix-unknown-sgx)
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Some changes occurred in run-make tests. cc @jieyouxu |
//@ ignore-wasm | ||
//@ ignore-nvptx64 | ||
//@ ignore-sgx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason why this can't run successfully for the sgx target. Our CI fails on the rustc command itself (line 69). The rest of the test looks at the generated archive, but this runs on the Linux platform, not sgx. So accessing files and directories are totally fine. Yes eventually enclaves are generated for the sgx plaform where it's too late to link in more binaries, but that doesn't happen at the rustc
level but later on.
Disabling tests/run-make/compiler-builtins for sgx target(x86_64-fortanix-unknown-sgx).