Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #123540

Merged
merged 15 commits into from
Apr 6, 2024
Merged

Rollup of 7 pull requests #123540

merged 15 commits into from
Apr 6, 2024

Commits on Mar 31, 2024

  1. Require LLVM_CONFIG to be set in rustc_llvm/build.rs

    This environment variable should always be set by bootstrap in
    `rustc_llvm_env`. The fallback is quite ugly and complicated, so
    removing it is nice.
    Nilstrieb committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    d651bae View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    9d70907 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. explaining DefKind::Field

    bvanjoi committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    889e571 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b14497 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c39c0e1 View commit details
    Browse the repository at this point in the history
  4. CFI: Don't rewrite ty::Dynamic directly

    Now that we're using a type folder, the arguments in predicates are
    processed automatically - we don't need to descend manually.
    
    We also want to keep projection clauses around, and this does so.
    maurer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    5083378 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. Configuration menu
    Copy the full SHA
    aa53bc0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    262670a View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#123294 - Nilstrieb:reuqire-llvm-config, r=c…

    …lubby789
    
    Require LLVM_CONFIG to be set in rustc_llvm/build.rs
    
    This environment variable should always be set by bootstrap in `rustc_llvm_env`. The fallback is quite ugly and complicated, so removing it is nice.
    
    https://github.com/rust-lang/rust/blob/bf71daedc29e7a240261acd1516378047e311a6f/src/bootstrap/src/core/build_steps/compile.rs#L1166
    
    I tried finding when this was added in git history, but it pointed all the way to "add build scripts" at which point I stopped digging more. This has always been here.
    
    cc `@nikic` `@cuviper` in case you happen to be aware of a deeper reason behind this
    
    r? bootstrap
    matthiaskrgr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    dea28d8 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#123467 - dpaoliello:archcoff, r=wesleywiser

    MSVC targets should use COFF as their archive format
    
    While adding support for Arm64EC I ran into an issue where the standard library's rlib was missing the "EC Symbol Table" which is required for the MSVC linker to find import library symbols (generated by Rust's `raw-dylib` feature) when building for EC.
    
    The root cause of the issue is that LLVM only generated symbol tables (including the EC Symbol Table) if the `ArchiveKind` is `COFF`, but the MSVC targets didn't set their archive format, so it was defaulting to GNU.
    matthiaskrgr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    84569f9 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#123498 - bvanjoi:docs, r=cjgillot

    explaining `DefKind::Field`
    matthiaskrgr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    7988adf View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#123519 - Urgau:session-cfg-check-cfg-improv…

    …ements, r=wesleywiser
    
    Improve cfg and check-cfg configuration
    
    This PR improves cfg and check-cfg configuration by:
     1. Extracting both logic under a common module (to improve the connection between the two)
     2. Adding more documentation, in particular some steps when adding a new cfg
    
    I also added my-self as mention in our triagebot conf for the new module.
    
    Inspired by rust-lang#123411 (comment)
    matthiaskrgr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    5b8b236 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#123525 - maurer:no-id-dyn2, r=compiler-errors

    CFI: Don't rewrite ty::Dynamic directly
    
    Now that we're using a type folder, the arguments in predicates are processed automatically - we don't need to descend manually.
    
    We also want to keep projection clauses around, and this does so.
    
    r? `@compiler-errors`
    matthiaskrgr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    ad3df49 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#123526 - estebank:issue-123442, r=compiler-…

    …errors
    
    Do not ICE when calling incorrectly defined `transmute` intrinsic
    
    Fix rust-lang#123442
    matthiaskrgr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    fc2dbbb View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#123528 - dtolnay:asyncgeninternals, r=compi…

    …ler-errors
    
    Hide async_gen_internals from standard library documentation
    
    These are from rust-lang#118420. It doesn't appear that there is any intention to ever make these APIs available to user code. These are just conveniences meant for the compiler's implementation of `async gen`. I don't think having them featured in documentation in <https://doc.rust-lang.org/1.77.1/core/task/enum.Poll.html> is appropriate.
    
    ![image](https://github.com/rust-lang/rust/assets/1940490/0a8ae90d-5c83-4ab1-b08a-50bad2433d69)
    matthiaskrgr committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    58ac1b4 View commit details
    Browse the repository at this point in the history