Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 6) #123574

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 6, 2024
@notriddle
Copy link
Contributor Author

r? rustdoc

@rustbot rustbot assigned fmease and unassigned Mark-Simulacrum Apr 13, 2024
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a couple of small nitpicks.

tests/rustdoc/send-impl-conditional-60726.rs Outdated Show resolved Hide resolved
tests/rustdoc-ui/ice-blanket-impl-56701.rs Show resolved Hide resolved
tests/rustdoc/auto-trait-lifetimes-56822.rs Outdated Show resolved Hide resolved
tests/rustdoc/issue-57180.rs Outdated Show resolved Hide resolved
@notriddle
Copy link
Contributor Author

@fmease The nitpicks should be resolved now.

@fmease
Copy link
Member

fmease commented Apr 15, 2024

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 15, 2024

📌 Commit ecbe327 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2024
…llaumeGomez

Rollup of 14 pull requests

Successful merges:

 - rust-lang#120781 (Correct usage note on OpenOptions::append())
 - rust-lang#121694 (sess: stabilize `-Zrelro-level` as `-Crelro-level`)
 - rust-lang#122521 (doc(bootstrap): add top-level doc-comment to utils/tarball.rs)
 - rust-lang#123491 (Fix ICE in `eval_body_using_ecx`)
 - rust-lang#123574 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 6))
 - rust-lang#123687 (Update ar_archive_writer to 0.2.0)
 - rust-lang#123721 (Various visionOS fixes)
 - rust-lang#123797 (Better graphviz output for SCCs and NLL constraints)
 - rust-lang#123990 (Make `suggest_deref_closure_return` more idiomatic/easier to understand)
 - rust-lang#123995 (Make `thir_tree` and `thir_flat` into hooks)
 - rust-lang#123998 (Opaque types have no namespace)
 - rust-lang#124001 (Fix docs for unstable_features lint.)
 - rust-lang#124006 (Move size assertions for `mir::syntax` types into the same file)
 - rust-lang#124011 (rustdoc: update the module-level docs of `rustdoc::clean`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e7c13c3 into rust-lang:master Apr 16, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2024
Rollup merge of rust-lang#123574 - notriddle:notriddle/issue-d, r=fmease

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 6)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
@notriddle notriddle deleted the notriddle/issue-d branch April 16, 2024 15:50
fmease added a commit to fmease/rust that referenced this pull request May 22, 2024
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
* rust-lang#123574

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2024
Rollup merge of rust-lang#125382 - notriddle:notriddle/issue-d, r=fmease

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
* rust-lang#123574

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request May 23, 2024
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7)

Follow up

* rust-lang/rust#116214
* rust-lang/rust#116432
* rust-lang/rust#116824
* rust-lang/rust#118105
* rust-lang/rust#119561
* rust-lang/rust#123574

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants