Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsafe to two functions with safety invariants #123867

Merged
merged 1 commit into from Apr 12, 2024
Merged

Add unsafe to two functions with safety invariants #123867

merged 1 commit into from Apr 12, 2024

Conversation

eduardosm
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2024

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 12, 2024
ChrisDenton
ChrisDenton reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one minor thing.

library/std/src/sys/pal/windows/thread.rs Outdated Show resolved Hide resolved
@ChrisDenton
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 12, 2024

📌 Commit a6ed319 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2024
@bors
Auto merge of rust-lang#123869 - matthiaskrgr:rollup-9kif9c9, r=matth…
7942405 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123654 (typeck: fix `?` suggestion span)
 - rust-lang#123807 (Remove `sys_common::thread`)
 - rust-lang#123834 (Don't do coroutine-closure-specific upvar analysis if tainted by errors)
 - rust-lang#123847 (Suppress `let else` suggestion for uninitialized refutable `let`s)
 - rust-lang#123857 (std::net: TcpListener shrinks the backlog argument to 32 for Haiku.)
 - rust-lang#123858 (zkvm: fix path to cmath in zkvm module)
 - rust-lang#123867 (Add `unsafe` to two functions with safety invariants)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3026204 into rust-lang:master Apr 12, 2024
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2024
@rust-timer
Unrolled build for rust-lang#123867
e3c8a5c 
Rollup merge of rust-lang#123867 - eduardosm:unsafe-fns, r=ChrisDenton

Add `unsafe` to two functions with safety invariants
@rustbot rustbot added this to the 1.79.0 milestone Apr 12, 2024
@eduardosm eduardosm deleted the unsafe-fns branch April 12, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton left review comments

Assignees

@ChrisDenton ChrisDenton

Labels
O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eduardosm @rustbot @ChrisDenton @bors