Stop using PolyTraitRef for closure/coroutine predicates already instantiated w placeholders
#123900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
force-pushed
the
nobound
branch
from
aee76d4
to
9a88d57
Compare
This comment has been minimized.
This comment has been minimized.
|
lmao @rustbot author |
rustbot
added
S-waiting-on-author
…antiated w placeholders
compiler-errors
force-pushed
the
nobound
branch
from
9a88d57
to
d2ec957
Compare
lcnr
reviewed
Apr 15, 2024
compiler/rustc_trait_selection/src/traits/error_reporting/type_err_ctxt_ext.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_trait_selection/src/traits/error_reporting/type_err_ctxt_ext.rs
Outdated
Show resolved
Hide resolved
| @@ -1079,8 +1079,8 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> { | |||
| }) | |||
| .map_err(|terr| { | |||
| SignatureMismatch(Box::new(SignatureMismatchData { | |||
There was a problem hiding this comment.
is that sometimes used with an uninstantiated binder?
There was a problem hiding this comment.
nope, it's always instantiated
There was a problem hiding this comment.
then we can remove the Binder from SignatureMismatchData 🤔
There was a problem hiding this comment.
isn't that what this PR is doing? 🤔
There was a problem hiding this comment.
?????????????????????????????????????????????? I might have been utterly confused
god knows what i was thinking. sorry
|
sorry, apparently unable to read diffs @bors r+ rollup |
|
@bors ping |
|
@bors r=lcnr rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2024
Stop using `PolyTraitRef` for closure/coroutine predicates already instantiated w placeholders r? lcnr
|
@bors retry yield to rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2024
…mpiler-errors Rollup of 4 pull requests Successful merges: - rust-lang#123900 (Stop using `PolyTraitRef` for closure/coroutine predicates already instantiated w placeholders) - rust-lang#123924 (Fix various bugs in `ty_kind_suggestion`) - rust-lang#123943 (Use the rustc_private libc less in tests) - rust-lang#123970 (zkvm: fix references to `os_str` module) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2024
Rollup merge of rust-lang#123900 - compiler-errors:nobound, r=lcnr Stop using `PolyTraitRef` for closure/coroutine predicates already instantiated w placeholders r? lcnr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? lcnr