Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vec_deque::Iter::as_slices and friends #123947

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add vec_deque::Iter::as_slices and friends #123947

wants to merge 1 commit into from
+142 −0

Conversation

chloekek
Copy link
Contributor

Add the following methods, that work similarly to VecDeque::as_slices:

  • alloc::collections::vec_deque::Iter::as_slices
  • alloc::collections::vec_deque::IterMut::into_slices
  • alloc::collections::vec_deque::IterMut::as_slices
  • alloc::collections::vec_deque::IterMut::as_mut_slices

Obtaining slices from a VecDeque iterator was not previously possible.

@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 14, 2024
@chloekek
Add vec_deque::Iter::as_slices and friends
4a5bcbb 
Add the following methods, that work similarly to VecDeque::as_slices:

 - alloc::collections::vec_deque::Iter::as_slices
 - alloc::collections::vec_deque::IterMut::into_slices
 - alloc::collections::vec_deque::IterMut::as_slices
 - alloc::collections::vec_deque::IterMut::as_mut_slices

Obtaining slices from a VecDeque iterator was not previously possible.
@chloekek chloekek marked this pull request as ready for review April 14, 2024 22:38
@joboet
Copy link
Contributor

joboet commented Apr 15, 2024

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 15, 2024
@rustbot rustbot assigned BurntSushi and unassigned joboet Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BurntSushi BurntSushi

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chloekek @rustbot @joboet @BurntSushi