Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link to async keyword docs #123952

Closed
wants to merge 1 commit into from

Conversation

shenawy29
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 15, 2024
@shenawy29
Copy link
Contributor Author

shenawy29 commented Apr 15, 2024

I've just noticed that the link, for some reason, is broken in the LSP documentation but works on the documentation website? This is on the stable build on Linux.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#16 exporting to docker image format
#16 sending tarball 29.6s done
#16 DONE 34.2s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id            := 99999999
---
  Downloaded boml v0.3.1
   Compiling boml v0.3.1
   Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
    Finished `release` profile [optimized] target(s) in 3.29s
     Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
##[group]Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.12s
##[endgroup]
##[group]Testing stage0 Linkcheck (x86_64-unknown-linux-gnu)
std/future/trait.Future.html:6: broken link - `/checkout/obj/build/x86_64-unknown-linux-gnu/std/keyword.async.html`
std/future/index.html:6: broken link - `/checkout/obj/build/x86_64-unknown-linux-gnu/std/keyword.async.html`
core/future/trait.Future.html:6: broken link - `/checkout/obj/build/x86_64-unknown-linux-gnu/std/keyword.async.html`
core/future/index.html:6: broken link - `/checkout/obj/build/x86_64-unknown-linux-gnu/std/keyword.async.html`
number of HTML files scanned: 38224
number of HTML redirects found: 12079
number of links checked: 3068673
number of links ignored due to external: 73200

@Mark-Simulacrum
Copy link
Member

Can you say more about where this link is showing up broken? It seems to work for me on https://doc.rust-lang.org/nightly/std/future/trait.Future.html and https://doc.rust-lang.org/nightly/core/future/trait.Future.html

@Mark-Simulacrum
Copy link
Member

Ah I missed your comment. I don't know much about the LSP documentation but I'd say that's probably a bug in the editor or in LSP tooling. I'd file an issue with rust-analyzer and see what they think, I doubt this is the only link affected.

@shenawy29
Copy link
Contributor Author

Ah I missed your comment. I don't know much about the LSP documentation but I'd say that's probably a bug in the editor or in LSP tooling. I'd file an issue with rust-analyzer and see what they think, I doubt this is the only link affected.

You're right, a lot of links are broken. I'll see if others have this issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants