Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink backtrace generation in std #123964

Closed
wants to merge 1 commit into from

Conversation

Mark-Simulacrum
Copy link
Member

r? @Mark-Simulacrum (for perf)

@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 15, 2024
@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2024
Shrink backtrace generation in std

r? `@Mark-Simulacrum` (for perf)
@bors
Copy link
Contributor

bors commented Apr 15, 2024

⌛ Trying commit 3f3b3b3 with merge 6bb7798...

@bors
Copy link
Contributor

bors commented Apr 15, 2024

☀️ Try build successful - checks-actions
Build commit: 6bb7798 (6bb779889bb749b512d00022777e298c9fda7fb7)

@rust-timer

This comment has been minimized.

@lukas-code
Copy link
Contributor

previous attempt: #122462

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6bb7798): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.9% [0.2%, 3.1%] 9
Regressions ❌
(secondary)
1.2% [0.3%, 3.0%] 54
Improvements ✅
(primary)
-1.2% [-4.0%, -0.2%] 21
Improvements ✅
(secondary)
-1.8% [-4.0%, -0.8%] 4
All ❌✅ (primary) -0.3% [-4.0%, 3.1%] 30

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
5.5% [1.3%, 8.0%] 6
Regressions ❌
(secondary)
7.2% [7.2%, 7.2%] 1
Improvements ✅
(primary)
-1.3% [-2.2%, -0.5%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.8% [-2.2%, 8.0%] 8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [1.9%, 3.4%] 9
Regressions ❌
(secondary)
2.2% [0.5%, 3.1%] 24
Improvements ✅
(primary)
-3.6% [-8.5%, -1.2%] 11
Improvements ✅
(secondary)
-2.4% [-3.4%, -1.0%] 3
All ❌✅ (primary) -0.8% [-8.5%, 3.4%] 20

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.7% [0.0%, 2.4%] 16
Regressions ❌
(secondary)
1.4% [0.2%, 2.5%] 68
Improvements ✅
(primary)
-1.6% [-9.7%, -0.0%] 48
Improvements ✅
(secondary)
-0.9% [-2.8%, -0.1%] 12
All ❌✅ (primary) -1.0% [-9.7%, 2.4%] 64

Bootstrap: 679.002s -> 676.764s (-0.33%)
Artifact size: 316.01 MiB -> 316.30 MiB (0.09%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 15, 2024
@Mark-Simulacrum
Copy link
Member Author

previous attempt: #122462

Thanks, hadn't seen that. Doesn't look like this had particularly good results on our overall binary sizes (https://perf.rust-lang.org/compare.html?start=5dcb678ad8dc23a518f9ddf907e6a08de923d05e&end=6bb779889bb749b512d00022777e298c9fda7fb7&stat=size%3Alinked_artifact&tab=artifact-size) though so going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants