Refactoring after the PlaceValue addition
#124153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @compiler-errors. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
scottmcm
force-pushed
the
more-placevalue
branch
from
058e198
to
d8a45ef
Compare
This comment has been minimized.
This comment has been minimized.
scottmcm
force-pushed
the
more-placevalue
branch
from
d8a45ef
to
7445e66
Compare
I added `PlaceValue` in 123775, but kept that one line-by-line simple because it touched so many places. This goes through to add more helpers & docs, and change some `PlaceRef` to `PlaceValue` where the type didn't need to be included. No behaviour changes.
scottmcm
force-pushed
the
more-placevalue
branch
from
7445e66
to
a9ef67f
Compare
scottmcm
commented
Apr 24, 2024
| /// of the specified size and alignment. | ||
| /// | ||
| /// The allocation itself is untyped. | ||
| pub fn alloca<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx, Value = V>>( |
There was a problem hiding this comment.
I'm happy that #122053 landed since it means that it's reasonable to alloca a PlaceValue without a type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
PlaceValuein #123775, but kept that one line-by-line simple because it touched so many places.This goes through to add more helpers & docs, and change some
PlaceReftoPlaceValuewhere the type didn't need to be included.No behaviour changes -- the codegen is exactly the same.