Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide suggestion to users with naughty elves #124446

Closed
wants to merge 1 commit into from
Closed

Provide suggestion to users with naughty elves #124446

wants to merge 1 commit into from

Conversation

Xiretza
Copy link
Contributor

@Xiretza Xiretza commented Apr 27, 2024

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 27, 2024
@Xiretza Xiretza changed the title Provide suggestion to users with naughy elves Provide suggestion to users with naughty elves Apr 27, 2024
@aDotInTheVoid aDotInTheVoid added A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The parsing of Rust source code to an AST. labels Apr 27, 2024
compiler-errors
compiler-errors requested changes Apr 28, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really prefer if we didn't commit more joke suggestions to the compiler, tbh. I don't believe it's worth to add more code into the parser just for inside-jokes/a funny post online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors requested changes

Assignees

@davidtwco davidtwco

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The parsing of Rust source code to an AST. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Xiretza @rustbot @compiler-errors @davidtwco @aDotInTheVoid