Allow monomorphization time const eval failures if the cause is a type layout issue #124516
+44
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
rustbot
added
the
T-compiler
oli-obk
changed the title
RalfJung
reviewed
Apr 30, 2024
| if !reported.is_tainted_by_errors() { | ||
| // Looks like the const is not captued by `required_consts`, that's bad. | ||
| span_bug!(span, "interpret const eval failure of {val:?} which is not in required_consts"); | ||
| } |
There was a problem hiding this comment.
I guess we don't need a delay_span_bug in the else since we in fact have an ErrorGuaranteed handle here?
Suggested change
| } | |
| } else { | |
| // const-eval will return "tainted" errors if e.g. the layout cannot | |
| // be computed as the type references non-existing names. | |
| // See <https://github.com/rust-lang/rust/issues/124348>. | |
| } |
| err_inval!(Layout(LayoutError::ReferencesError(guar))) => { | ||
| ErrorHandled::Reported(guar.into(), span.unwrap_or(DUMMY_SP)) | ||
| } | ||
| err_inval!(Layout(LayoutError::ReferencesError(guar))) => ErrorHandled::Reported( |
There was a problem hiding this comment.
What if there is aSizeOverflow in a promoted?
This PR seems like a good step so I am okay with landing it, but it seems to me there's still a potential for ICEs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung
fixes #124348