Rollup of 7 pull requests

[matthiaskrgr]

Successful merges:

• Implement ptr_as_ref_unchecked #122492 (Implement ptr_as_ref_unchecked)
• Fix cannot usage in time.rs #123815 (Fix cannot usage in time.rs)
• default_alloc_error_hook: explain difference to default __rdl_oom in alloc #124059 (default_alloc_error_hook: explain difference to default __rdl_oom in alloc)
• Add raw identifier in a typo suggestion #124510 (Add raw identifier in a typo suggestion)
• Describe and use CStr literals in CStr and CString docs #124593 (Describe and use CStr literals in CStr and CString docs)
• CI: remove env-x86_64-apple-tests YAML anchor #124630 (CI: remove env-x86_64-apple-tests YAML anchor)
• Migrate run-make/doctests-keep-binaries to new rmake.rs format #124658 (Migrate run-make/doctests-keep-binaries to new rmake.rs format)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=7

[bors]

📌 Commit cc9f8d9 has been approved by matthiaskrgr

It is now in the queue for this repository.

[rust-log-analyzer]

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Getting action download info
Download action repository 'msys2/setup-msys2@v2.22.0' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea)
Download action repository 'actions/checkout@v4' (SHA:0ad4b8fadaa221de15dcec353f45205ec38ea70b)
Download action repository 'actions/upload-artifact@v4' (SHA:65462800fd760344b1a7b4382951275a0abb4808)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh

COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt \
    && pip3 install virtualenv
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---

#12 [5/8] COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
#12 DONE 0.0s

#13 [6/8] RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt     && pip3 install virtualenv
#13 0.408   Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
#13 0.420 Collecting boolean-py==4.0
#13 0.424   Downloading boolean.py-4.0-py3-none-any.whl (25 kB)
#13 0.437 Collecting chardet==5.1.0
---
#13 3.436 Building wheels for collected packages: reuse
#13 3.437   Building wheel for reuse (pyproject.toml): started
#13 3.757   Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.758   Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=181117 sha256=f5f58750481f69515c2c0d1d503daf565e2565c370d07fc6aeb95fe3498b4269
#13 3.758   Stored in directory: /tmp/pip-ephem-wheel-cache-3hovou7v/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
#13 3.761 Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
#13 3.783   Attempting uninstall: setuptools
#13 3.784     Found existing installation: setuptools 59.6.0
#13 3.785     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
---
#13 4.991   Downloading virtualenv-20.26.1-py3-none-any.whl (3.9 MB)
#13 5.050      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.9/3.9 MB 69.0 MB/s eta 0:00:00
#13 5.101 Collecting filelock<4,>=3.12.2
#13 5.105   Downloading filelock-3.14.0-py3-none-any.whl (12 kB)
#13 5.132 Collecting platformdirs<5,>=3.9.1
#13 5.136   Downloading platformdirs-4.2.1-py3-none-any.whl (17 kB)
#13 5.152 Collecting distlib<1,>=0.3.7
#13 5.155   Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)
#13 5.161      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.9/468.9 KB 99.9 MB/s eta 0:00:00
#13 5.245 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 5.406 Successfully installed distlib-0.3.8 filelock-3.14.0 platformdirs-4.2.1 virtualenv-20.26.1
#13 DONE 5.5s

#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k:      196544 kB
DirectMap2M:     8192000 kB
DirectMap1G:    10485760 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
    Finished `dev` profile [unoptimized] target(s) in 0.03s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/d6d3b342e85272f5e75c0d7a1dd3a1d8becb40ac/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-d6d3b342e85272f5e75c0d7a1dd3a1d8becb40ac-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
   Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
    Finished `release` profile [optimized] target(s) in 24.73s
##[endgroup]
fmt check
##[error]Diff in /checkout/tests/run-make/doctests-keep-binaries/rmake.rs at line 8:
 fn setup_test_env<F: FnOnce(&Path, &Path)>(callback: F) {
     let out_dir = tmp_dir().join("doctests");
     create_dir(&out_dir).expect("failed to create doctests folder");
-    rustc()
-        .input("t.rs")
-        .crate_type("rlib")
-        .run();
+    rustc().input("t.rs").crate_type("rlib").run();
     callback(&out_dir, &tmp_dir().join("libt.rlib"));
     remove_dir_all(out_dir);
 }
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/tests/run-make/doctests-keep-binaries/rmake.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
  local time: Fri May  3 18:30:34 UTC 2024
  network time: Fri, 03 May 2024 18:30:34 GMT
##[error]Process completed with exit code 1.
Post job cleanup.