Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: enable arbitrary try builds, take two #124743

Merged
merged 5 commits into from
May 9, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 5, 2024

Fixed version of #124631, which hopefully won't completely break our CI this time πŸ€¦β€β™‚οΈ Sorry once again. Only the last commit is new.

r? @pietroalbini

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 5, 2024
@matthiaskrgr
Copy link
Member

@bors treeclosed-

@@ -136,7 +136,7 @@ def calculate_jobs(run_type: WorkflowRunType, job_data: Dict[str, Any]) -> List[
raise Exception(f"Custom job(s) `{unknown_jobs}` not found in auto jobs")

return add_base_env(name_jobs(jobs, "try"), job_data["envs"]["try"])
elif run_type is AutoRunType:
elif isinstance(run_type, AutoRunType):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the bug that caused the PR to run no jobs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops.

@pietroalbini
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented May 9, 2024

πŸ“Œ Commit b3e9060 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2024
@bors
Copy link
Contributor

bors commented May 9, 2024

βŒ› Testing commit b3e9060 with merge 6f7e00a...

@bors
Copy link
Contributor

bors commented May 9, 2024

β˜€οΈ Test successful - checks-actions
Approved by: pietroalbini
Pushing 6f7e00a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2024
@bors bors merged commit 6f7e00a into rust-lang:master May 9, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 9, 2024
@Kobzol Kobzol deleted the arbitrary-try-build branch May 9, 2024 13:02
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6f7e00a): comparison URL.

Overall result: βŒβœ… regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 1
Improvements βœ…
(primary)
-2.8% [-2.8%, -2.8%] 1
Improvements βœ…
(secondary)
-1.1% [-1.1%, -1.1%] 1
All βŒβœ… (primary) -2.8% [-2.8%, -2.8%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.5% [3.5%, 3.5%] 1
Improvements βœ…
(primary)
- - 0
Improvements βœ…
(secondary)
- - 0
All βŒβœ… (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements βœ…
(primary)
-2.6% [-2.6%, -2.6%] 1
Improvements βœ…
(secondary)
- - 0
All βŒβœ… (primary) -2.6% [-2.6%, -2.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.974s -> 673.446s (-0.08%)
Artifact size: 315.95 MiB -> 315.79 MiB (-0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants