Removed rustdoc comments on pub mod statements in std::io's mod.rs. Twea... #12490
Conversation
| @@ -300,46 +300,46 @@ pub use self::buffered::{BufferedReader, BufferedWriter, BufferedStream, | |||
| LineBufferedWriter}; | |||
| pub use self::comm_adapters::{PortReader, ChanWriter}; | |||
|
|
|||
| /// Various utility functions useful for writing I/O tests | |||
| // Various utility functions useful for writing I/O tests | |||
There was a problem hiding this comment.
Can you move this comment inside the module?
|
I'd also be find with deleting these doc-comments instead of just making them comments. |
|
@alexcrichton Done! |
…od.rs file. Added summary doc-comments to test.rs, util.rs and stdio.rs.
|
This appears to have picked up a few extra commits. I would recommend using |
|
Shoot. It would seem that I'm not very talented at rebasing. I was trying to do that when I somehow created the merge commits. I have a master branch and this bugfix branch, 'doc-fix-12386'. Mozilla's repo is my upstream. Whenever I run |
|
It may have been the case that you just needed to start a new branch and cherry-pick your one commit on top, but I'm not entirely sure. Regardless, it seems to have been sorted out! Sorry I forgot to mention this earlier, but could you also mention the issue in the commit message itself? If you phrase it like |
|
Sure, I'd be happy to. It's not possible to change the commit message once it's been pushed, is it? How do you recommend I amend it? |
|
Nevermind, I just reset the branch and reapplied my changes with the new message. |
|
You can also use |
|
Oh! Educational. Thanks! On Sun, Feb 23, 2014 at 11:47 PM, Alex Crichton notifications@github.comwrote:
|
…, r=Veykril fix: complete non-std enum at the start of `use` completions close: rust-lang#12421
Attn: @huonw
Addresses #12386.