Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an helper to move the files #124975

Merged
merged 1 commit into from May 15, 2024
Merged

Use an helper to move the files #124975

merged 1 commit into from May 15, 2024
+24 −7

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented May 10, 2024

In case the source is not in the same filesystem.

See openwrt/packages@c1b3e04#commitcomment-141886468

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2024

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 10, 2024
lu-zero referenced this pull request in openwrt/packages May 10, 2024
@1715173329
rust: Update to 1.78.0
c1b3e04 
- Switch back to .gz tarball
- Replace local bootstrap cache hack with upstreamed option

Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
@bors
Copy link
Contributor

bors commented May 12, 2024

☔ The latest upstream changes (presumably #124883) made this pull request unmergeable. Please resolve the merge conflicts.

feckert added a commit to TDT-AG/packages that referenced this pull request May 13, 2024
@feckert
rust: fix remote filesystem issue
2e66d60 
If the download directory is on another filesystem (NFS), then the
current implementation of bootstrapping rust fails. Because the syscall
(rename) does not work on crossing filesystem boundary.

This patch has already been send upsream to the main rust repository and
is currently under disussion.
rust-lang/rust#124975

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
feckert added a commit to TDT-AG/packages that referenced this pull request May 13, 2024
@feckert
rust: fix remote filesystem issue
2b2e9b0 
If the download directory is on another filesystem (NFS), then the
current implementation of bootstrapping rust fails. Because the 'syscall'
(rename) does not work on crossing filesystem boundary.

This patch has already been send upstream to the main rust repository and
is currently under discussion.
rust-lang/rust#124975

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
@feckert feckert mentioned this pull request May 13, 2024
Merged
@lu-zero
Use an helper to move the files
4db00fe 
In case the source is not in the same filesystem.
@clubby789
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 14, 2024

📌 Commit 4db00fe has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 14, 2024
@jieyouxu
Rollup merge of rust-lang#124975 - lu-zero:move_file, r=clubby789
6838d6c 
Use an helper to move the files

In case the source is not in the same filesystem.

See openwrt/packages@c1b3e04#commitcomment-141886468
@jieyouxu jieyouxu mentioned this pull request May 14, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2024
@bors
Auto merge of rust-lang#125131 - jieyouxu:rollup-oqprchr, r=jieyouxu
7cd7f2d 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#124746 (`rustc --explain E0582` additional example)
 - rust-lang#124975 (Use an helper to move the files)
 - rust-lang#125027 (Migrate `run-make/c-link-to-rust-staticlib` to `rmake`)
 - rust-lang#125084 (`rustc_hir_typeck`: Account for `skipped_ref_pats` in `expr_use_visitor`)
 - rust-lang#125104 (Migrate `run-make/no-cdylib-as-rdylib` to `rmake`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented May 14, 2024

⌛ Testing commit 4db00fe with merge 778e110...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2024
@bors
Auto merge of rust-lang#124975 - lu-zero:move_file, r=clubby789
778e110 
Use an helper to move the files

In case the source is not in the same filesystem.

See openwrt/packages@c1b3e04#commitcomment-141886468
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
##[endgroup]
[TIMING] core::build_steps::tool::ToolBuild { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu, tool: "lint-docs", path: "src/tools/lint-docs", mode: ToolBootstrap, source_type: InTree, extra_features: [], allow_features: "" } -- 8.530
[TIMING] core::build_steps::tool::LintDocs { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu } -- 0.004
##[group]Running stage2 lint-docs (aarch64-unknown-linux-gnu)
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

Session terminated, killing shell...::group::Clock drift check
  network time:  ...killed.
##[error]The operation was canceled.
Cleaning up orphan processes

@bors
Copy link
Contributor

bors commented May 15, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 15, 2024
@clubby789
Copy link
Contributor

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2024
@fmease fmease mentioned this pull request May 15, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2024
@bors
Auto merge of rust-lang#125144 - fmease:rollup-4uft293, r=fmease
ade234d 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#124307 (Optimize character escaping.)
 - rust-lang#124975 (Use an helper to move the files)
 - rust-lang#125027 (Migrate `run-make/c-link-to-rust-staticlib` to `rmake`)
 - rust-lang#125038 (Invert comparison in `uN::checked_sub`)
 - rust-lang#125104 (Migrate `run-make/no-cdylib-as-rdylib` to `rmake`)
 - rust-lang#125137 (MIR operators: clarify Shl/Shr handling of negative offsets)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2e70bea into rust-lang:master May 15, 2024
6 of 7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2024
@rust-timer
Unrolled build for rust-lang#124975
e2144d3 
Rollup merge of rust-lang#124975 - lu-zero:move_file, r=clubby789

Use an helper to move the files

In case the source is not in the same filesystem.

See openwrt/packages@c1b3e04#commitcomment-141886468
@lu-zero lu-zero deleted the move_file branch May 15, 2024 16:06
feckert added a commit to TDT-AG/packages that referenced this pull request May 16, 2024
@feckert
rust: add patch to fix remote filesystem issue
23aa958 
If the download directory is on another filesystem (NFS), then the
current implementation of bootstrapping rust fails. Because the 'syscall'
(rename) does not work on crossing filesystem boundary.

This chnage was already merged upstream to the github main rust repository.
rust-lang/rust#124975

The patch has been rebased so that it can be applied correctly.
No functional change.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
@feckert
Copy link

feckert commented May 16, 2024

@bors thanks for fixing this issue.

feckert added a commit to TDT-AG/packages that referenced this pull request May 16, 2024
@feckert
rust: add patch to fix remote filesystem issue
6b6c74d 
If the download directory is on another filesystem (NFS), then the
current implementation of bootstrapping rust fails. Because the 'syscall'
(rename) does not work on crossing filesystem boundary.

This chnage was already merged upstream to the github main rust repository.
rust-lang/rust#124975

The patch has been rebased so that it can be applied correctly.
No functional change.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
liudf0716 pushed a commit to liudf0716/packages that referenced this pull request May 27, 2024
@feckert @liudf0716
rust: add patch to fix remote filesystem issue
849c5b1 
If the download directory is on another filesystem (NFS), then the
current implementation of bootstrapping rust fails. Because the 'syscall'
(rename) does not work on crossing filesystem boundary.

This chnage was already merged upstream to the github main rust repository.
rust-lang/rust#124975

The patch has been rebased so that it can be applied correctly.
No functional change.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klensy klensy klensy left review comments

Assignees

@clubby789 clubby789

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lu-zero @rustbot @bors @clubby789 @rust-log-analyzer @feckert @klensy