-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate run-make/issue-11908
to new rmake.rs
format
#125031
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tests/run-make/issue-11908/rmake.rs
Outdated
// Note that this relies on `liburl` to be in the path somewhere else. | ||
// Our aux-built libraries will collide with liburl (they have | ||
// the same version listed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wtf? This seems rather fragile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment even accurate anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentatively, it seems like the test author, in this commit, implemented the directory moving commands to fix the collision, but didn't remove the comment. I have removed the comment, but let me know if you think it should be kept in some way, since we are not 100% sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless this fails because of liburl, the comment seems outdated
☔ The latest upstream changes (presumably #125120) made this pull request unmergeable. Please resolve the merge conflicts. |
9f64368
to
1236ff3
Compare
Thanks, r=me after CI is green @bors delegate+ |
✌️ @Oneirical, you can now approve this pull request! If @jieyouxu told you to " |
This comment has been minimized.
This comment has been minimized.
Yeah, -Clto seems better because that flag can take no value (default) or thin/fat |
☀️ Test successful - checks-actions |
Finished benchmarking commit (9e7aff7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 679.642s -> 679.01s (-0.09%) |
Part of #121876 and the associated Google Summer of Code project.
Set as draft, because I have a few concerns:
target().contains("darwin")
is a good way of checking that the target is on OSX.dylib
part of the test adapts to different target platforms, but not therlib
part. Isrlib
named the same on all platforms?