remove git-commit-hash file from the source tarballs
#125176
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
We put 2 files in source tarballs that contains git related informations. 1: git-commit-info: ```txt 9b00956 9b00956 2024-04-29 ``` 2: git-commit-hash: ```txt 9b00956 ``` As the commit hash already covered in the `git-commit-info` file, this change removes the use of git-commit-hash and uses git-commit-info file instead. Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
remove-git-commit-hash
branch
from
ba6a96b
to
f803f7e
Compare
|
This seems like it complicates downstream consumption (a little) since it needs parsing rather than just passing the file to e.g. git or other tooling. It's simple parsing, but still extra work. It's also at least theoretically a breaking change since tooling could be relying on this file existing. Is there a motivation for making this change? It doesn't feel like there's much of a problem with a few extra files. |
There's no particular reason; I just wanted to consolidate some duplicated stuff in the bootstrap. |
|
In that case I'll go ahead and close. I don't think this is worth the potential for breakage without some stronger justification. |
We put 2 files in source tarballs that contains git related informations.
1: git-commit-info:
2: git-commit-hash:
As the commit hash already covered in the
git-commit-infofile, this change removes the use of git-commit-hash and uses git-commit-info file instead.