Migrate run-make/issue64319 to rmake and rename
#125215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-testsuite
|
I think it's fine as is, I don't see making this into macros or what not makes it that much easier to understand. Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2024
Rollup of 3 pull requests Successful merges: - rust-lang#125213 (Migrate `run-make/static-unwinding` to `rmake`) - rust-lang#125215 (Migrate `run-make/issue64319` to `rmake` and rename) - rust-lang#125221 (Migrate `run-make/issue-28766` to `rmake`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2024
Rollup merge of rust-lang#125215 - Oneirical:easy-test-the-second, r=jieyouxu Migrate `run-make/issue64319` to `rmake` and rename Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). ~~I noticed that the Makefile was not listed in `allowed-run-makefiles` in Tidy. Does this mean the test was being ignored?~~ EDIT: No, it was there, just not in its expected alphabetical order. EDIT2: Perhaps it could be interesting to clean this test visually by looping over the `rustc` calls, like in rust-lang#125227.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121876 and the associated Google Summer of Code project.
I noticed that the Makefile was not listed inEDIT: No, it was there, just not in its expected alphabetical order.allowed-run-makefilesin Tidy. Does this mean the test was being ignored?EDIT2: Perhaps it could be interesting to clean this test visually by looping over the
rustccalls, like in #125227.