add a normalizes-to fast path #125334
add a normalizes-to fast path #125334
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler/rustc_trait_selection/src/solve/normalizes_to/fast_reject.rs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
compiler/rustc_trait_selection/src/solve/normalizes_to/fast_reject.rs
Outdated
Show resolved
Hide resolved
rust-cloud-vms
bot
force-pushed
the
normalizes-to-rigid-fastpath
branch
from
b416190
to
2322dff
Compare
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
| #[instrument(level = "trace", skip(tcx), ret)] | ||
| fn no_applicable_blanket_impls<'tcx>(tcx: TyCtxt<'tcx>, trait_def_id: DefId) -> bool { | ||
| // FIXME(ptr_metadata): There's currently a builtin impl for `Pointee` which | ||
| // applies for all `T` as long as `T: Sized` holds. THis impl should |
There was a problem hiding this comment.
| // applies for all `T` as long as `T: Sized` holds. THis impl should | |
| // applies for all `T` as long as `T: Sized` holds. This impl should |
| // pretty much everything. Just return `true` in that case. | ||
| ty::Param(_) | ty::Error(_) | ty::Alias(..) => return true, | ||
| ty::Param(_) | ty::Error(_) | ty::Alias(..) | ty::Infer(_) | ty::Placeholder(..) => { |
There was a problem hiding this comment.
This treats params always as bound vars (which is true for unsubstituted impl headers), vs when they come from the environment they should be treated as placeholders (param-env candidate matching).
I think drcx should be reworked to make this distinction, so we don't return true more than we need to.
There was a problem hiding this comment.
Ideally this could then be used when matching param-env candidates in the new and old solvers, so we can avoid instantiating binders and doing type equality when it's useless.
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #125665) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixes the minimization in rust-lang/trait-system-refactor-initiative#109. It does not fix rayon as rayon has a blanket impl of
ParallelIterator.r? @compiler-errors