Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read_buf uses in std #125404

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented May 22, 2024

Following lib-team decision here: #78485 (comment)

@rustbot
Copy link
Collaborator

rustbot commented May 22, 2024

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 22, 2024
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Caused by:
  process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/lock_api-7d87a5aef10d3105/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at /cargo/registry/src/index.crates.io-6f17d22bba15001f/autocfg-1.3.0/src/lib.rs:132:20:
  called `Result::unwrap()` on an `Err` value: Error { kind: Other("could not find rustc release") }
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:05:05
+ set -e
+ cat /tmp/toolstate/toolstates.json
+ cat /tmp/toolstate/toolstates.json
{"lld-wrapper":"test-fail"}
+ python3 ../x.py test --stage 2 check-tools
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
ERROR: Tool `book` was not recorded in tool state.
ERROR: Tool `nomicon` was not recorded in tool state.
ERROR: Tool `reference` was not recorded in tool state.
ERROR: Tool `rust-by-example` was not recorded in tool state.
ERROR: Tool `edition-guide` was not recorded in tool state.
ERROR: Tool `embedded-book` was not recorded in tool state.
  local time: Wed May 22 16:05:46 UTC 2024
  network time: Wed, 22 May 2024 16:05:46 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@workingjubilee
Copy link
Contributor

Waiting to see how a bit more of the discussion plays out given #78485 (comment)

@briansmith
Copy link
Contributor

It seems like there should be tests for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants