SmartPointer derive-macro #125575
Merged
SmartPointer derive-macro #125575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
dingxiangfei2009
force-pushed
the
derive-smart-ptr
branch
from
0c32103
to
8448bc7
Compare
This comment has been minimized.
This comment has been minimized.
dingxiangfei2009
force-pushed
the
derive-smart-ptr
branch
from
8448bc7
to
ab3ebe1
Compare
This comment has been minimized.
This comment has been minimized.
dingxiangfei2009
force-pushed
the
derive-smart-ptr
branch
from
ab3ebe1
to
a33685e
Compare
This comment has been minimized.
This comment has been minimized.
dingxiangfei2009
force-pushed
the
derive-smart-ptr
branch
from
a33685e
to
37f682c
Compare
|
I don't feel competent reviewing this r? compiler |
4 tasks
|
r? compiler |
davidtwco
approved these changes
Jun 20, 2024
dingxiangfei2009
force-pushed
the
derive-smart-ptr
branch
from
37f682c
to
8804882
Compare
Co-authored-by: Wedson Almeida Filho <walmeida@microsoft.com>
dingxiangfei2009
force-pushed
the
derive-smart-ptr
branch
from
8804882
to
f1be59f
Compare
davidtwco
approved these changes
Jun 24, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2024
…mpiler-errors Rollup of 11 pull requests Successful merges: - rust-lang#124460 (Show notice about "never used" of Debug for enum) - rust-lang#124712 (Deprecate no-op codegen option `-Cinline-threshold=...`) - rust-lang#125082 (Remove `MaybeUninit::uninit_array()` and replace it with inline const blocks.) - rust-lang#125575 (SmartPointer derive-macro) - rust-lang#126413 (compiletest: make the crash test error message abit more informative) - rust-lang#126673 (Ensure we don't accidentally succeed when we want to report an error) - rust-lang#126682 (coverage: Overhaul validation of the `#[coverage(..)]` attribute) - rust-lang#126899 (Suggest inline const blocks for array initialization) - rust-lang#126904 (Small fixme in core now that NonZero is generic) - rust-lang#126909 (add `@kobzol` to bootstrap team for triagebot) - rust-lang#126911 (Split the lifetimes of `MirBorrowckCtxt`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2024
Rollup merge of rust-lang#125575 - dingxiangfei2009:derive-smart-ptr, r=davidtwco SmartPointer derive-macro <!-- If this PR is related to an unstable feature or an otherwise tracked effort, please link to the relevant tracking issue here. If you don't know of a related tracking issue or there are none, feel free to ignore this. This PR will get automatically assigned to a reviewer. In case you would like a specific user to review your work, you can assign it to them by using r? <reviewer name> --> Possibly replacing rust-lang#123472 for continued upkeep of the proposal rust-lang/rfcs#3621 and implementation of the tracking issue rust-lang#123430. cc `@Darksonn` `@wedsonaf`
|
Assignment is not allowed on a closed PR. |
Kixunil
reviewed
Jul 13, 2024
| let s_ty = cx.ty_ident(span, Ident::new(sym::__S, span)); | ||
| let mut alt_self_params = self_params; | ||
| alt_self_params[pointee_param_idx] = GenericArg::Type(s_ty.clone()); | ||
| let alt_self_type = cx.ty_path(cx.path_all(span, false, vec![name_ident], alt_self_params)); |
There was a problem hiding this comment.
It looks like the trait bounds on pointee need to be copied for __S somewhere here. See #127647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly replacing #123472 for continued upkeep of the proposal rust-lang/rfcs#3621 and implementation of the tracking issue #123430.
cc @Darksonn @wedsonaf