Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various HirTyLowerer cleanups #125819

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Various HirTyLowerer cleanups #125819

merged 7 commits into from
Jun 5, 2024

Commits on Jun 5, 2024

  1. Use a LocalDefId for HirTyLowerer::item_def_id, since we only eve… 

    …r (can) use it for local items
    @oli-obk
    oli-obk committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    dc020ae View commit details
    Browse the repository at this point in the history

  2. Simplify some code paths and remove an unused field 

    `ct_infer` and `lower_ty` will correctly result in an error constant or type respectively, as they go through a `HirTyLowerer` method (just like `HirTyLowerer::allow_infer` is a method implemented by both implementors
    @oli-obk
    oli-obk committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    9d387d1 View commit details
    Browse the repository at this point in the history

  3. Remove an Option and instead eagerly create error lifetimes

    @oli-obk
    oli-obk committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    abd308b View commit details
    Browse the repository at this point in the history

  4. Only collect infer vars to error about in case infer vars are actuall… 

    …y forbidden
    @oli-obk
    oli-obk committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6a2e15a View commit details
    Browse the repository at this point in the history

  5. Remove allows_infer now that every use of it is delegated to `HirTy… 

    …Lowerer`
    @oli-obk
    oli-obk committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    7870674 View commit details
    Browse the repository at this point in the history

  6. Remove some unnecessary explicit lifetimes

    @oli-obk
    oli-obk committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    4146b82 View commit details
    Browse the repository at this point in the history

  7. Unify optional param info with object lifetime default boolean into a… 

    …n enum that exhaustively supports all call sites
    @oli-obk
    oli-obk committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c8a331a View commit details
    Browse the repository at this point in the history