Move ZST ABI handling to rustc_target
#125854
Open
+767
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, target specific handling of ZST function call ABI (specifically passing them indirectly instead of ignoring them) is handled in
rustc_ty_utils
, whereas all other target specific function call ABI handling is located inrustc_target
. This PR moves the ZST handling torustc_target
so that all the target-specific function call ABI handling is in one place. In the process of doing so, this PR fixes #125850 by ensuring that ZST arguments are always correctly ignored in the x86-64"sysv64"
ABI; any code which would be affected by this fix would have ICEd before this PR. Tests are also added using#[rustc_abi(debug)]
to ensure this behaviour does not regress.Fixes #125850