Remove src/tools/rust-demangler
#125880
Remove src/tools/rust-demangler
#125880
Conversation
|
r? @clubby789 rustbot has assigned @clubby789. Use |
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
It seems to be in a rustup component, and if that’s published then it can be tricky to just delete, maybe double check that? We definitely had issues in the past when removing components (rls and save analysis come to mind), I’m not sure why, but could be related to backwards compatibility or lack thereof in rustup itself and may have been fixed since. (Also this looks bootstrap related, so does it need a t-compiler mcp?) |
|
We upload the artifact to the CI bucket but it's not accessible through rustup (not present in the manifest). Checked current nightly with curl -O https://static.rust-lang.org/dist/channel-rust-nightly.toml and grepping that file for rust-demangler. |
clubby789
added
the
S-waiting-on-MCP
|
Another rebase for good luck. The final comment period has passed without any objections, so we should be able to go ahead and remove this. |
bors
added
S-waiting-on-bors
Rollup of 6 pull requests Successful merges: - rust-lang#125447 (Allow constraining opaque types during subtyping in the trait system) - rust-lang#125766 (MCDC Coverage: instrument last boolean RHS operands from condition coverage) - rust-lang#125880 (Remove `src/tools/rust-demangler`) - rust-lang#126154 (StorageLive: refresh storage (instead of UB) when local is already live) - rust-lang#126572 (override user defined channel when using precompiled rustc) - rust-lang#126662 (Unconditionally warn on usage of `wasm32-wasi`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#125880 - Zalathar:demangler, r=oli-obk Remove `src/tools/rust-demangler` `rust-demangler` is a small binary that reads a list of mangled symbols from stdin, demangles them (using the `rustc-demangle` library crate), and prints the demangled symbols to stdout. It was added as part of the initial implementation of coverage instrumentation in 2020/2021, so that coverage tests could pass it to `llvm-cov --Xdemangler` when generating coverage reports. It has been largely untouched since then. As of rust-lang#125816 it is no longer used by coverage tests, and has no remaining in-tree uses. There is code in bootstrap to build and package the demangler, but it's unclear where the resulting binaries actually end up, or whether there's any reasonable way for `rustup` users to obtain them. --- For users needing a command-line demangler, `rustfilt` exists and is more actively maintained. It's also quite easy to use the `rustc-demangle` library to build a custom command-line demangler if necessary, with only a few lines of code. The tool's name (`rust-demangler`) is easily confused with the name of the library crate `rustc-demangle`, so removing the tool will eliminate that confusion. There also doesn't appear to be much reason to use `rust-demangler` over `rustfilt`. --- This PR therefore removes the tool, and removes all of its associated code from bootstrap. MCP filed: rust-lang/compiler-team#754
This was removed in rust-lang/rust#125880 Original-Bug: 348390430 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/1069232 Original-Revision: 8447a3802f23d09bba93efd4b305b9801b2c6c8e GitOrigin-RevId: a4e01d658f6626447382ba0b1dbcce95bd3b3a73 Change-Id: Ia537bbb0698b3362ca4b6ada5c2ae816cc1e30e9
rust-demangleris a small binary that reads a list of mangled symbols from stdin, demangles them (using therustc-demanglelibrary crate), and prints the demangled symbols to stdout.It was added as part of the initial implementation of coverage instrumentation in 2020/2021, so that coverage tests could pass it to
llvm-cov --Xdemanglerwhen generating coverage reports. It has been largely untouched since then.As of #125816 it is no longer used by coverage tests, and has no remaining in-tree uses.
There is code in bootstrap to build and package the demangler, but it's unclear where the resulting binaries actually end up, or whether there's any reasonable way for
rustupusers to obtain them.For users needing a command-line demangler,
rustfiltexists and is more actively maintained. It's also quite easy to use therustc-demanglelibrary to build a custom command-line demangler if necessary, with only a few lines of code.The tool's name (
rust-demangler) is easily confused with the name of the library craterustc-demangle, so removing the tool will eliminate that confusion. There also doesn't appear to be much reason to userust-demangleroverrustfilt.This PR therefore removes the tool, and removes all of its associated code from bootstrap.
MCP filed: rust-lang/compiler-team#754