rustfmt more tests #125948
rustfmt more tests #125948
Conversation
Note: I inserted blank lines between the items in `pretty-expanded/input.rs` because it looked better that way.
rustbot
added
A-meta
|
Some changes occurred in GUI tests. |
This comment has been minimized.
This comment has been minimized.
This is trivial, because the directory contains no `.rs` files.
nnethercote
force-pushed
the
rustfmt-more-tests
branch
from
068921b
to
d2ea692
Compare
|
I'm not sure if some of the rustdoc tests are always run locally, and on PR CI, compared to post-review, so we may we surprised by failures in obscure builders, we'll see. It's also possible that e.g. some of the js-std suites are never intended to contain rust files, in which case it's a tossup whether to explicitly ignore the folder and document it as such. I'll let Guillaume chime in on this by the time the PR reaches the top of the queue. @bors r+ rollup=iffy |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Remove `tests/run-make-fulldeps/pretty-expanded` This was an ancient regression test for rust-lang#12685, caused by `-Zunpretty=expanded` crashing on certain code produced by `#[derive(RustcEncodable)]`. Given that this test predates `//@ pretty-expanded` tests, and was tied to ancient implementation details of the pretty-printer and `#[derive(RustcEncodable)]` (which the test no longer even uses), I think we can safely delete it. --- Spotted via rust-lang#125948.
|
Finished benchmarking commit (bc33782): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.596s -> 669.797s (-0.56%) |
Rollup merge of rust-lang#125973 - Zalathar:pretty, r=lqd Remove `tests/run-make-fulldeps/pretty-expanded` This was an ancient regression test for rust-lang#12685, caused by `-Zunpretty=expanded` crashing on certain code produced by `#[derive(RustcEncodable)]`. Given that this test predates `//@ pretty-expanded` tests, and was tied to ancient implementation details of the pretty-printer and `#[derive(RustcEncodable)]` (which the test no longer even uses), I think we can safely delete it. --- Spotted via rust-lang#125948.
This finishes the formatting of tests begun in #125759 and continued in #125912.
r? @lqd