Add hard error and migration lint for unsafe attrs #126177

carbotaniuman · 2024-06-08T23:45:37Z

More implementation work for #123757

This adds the migration lint for unsafe attributes, as well as making it a hard error in Rust 2024.

rustbot · 2024-06-08T23:45:45Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu

Thank you for working on this. The implementation looks good to me overall, I just have some questions and nits.

compiler/rustc_lint_defs/src/builtin.rs

jieyouxu · 2024-06-09T17:01:04Z

compiler/rustc_parse/messages.ftl

@@ -364,6 +364,10 @@ parse_inner_doc_comment_not_permitted = expected outer doc comment
    .label_does_not_annotate_this = the inner doc comment doesn't annotate this {$item}
    .sugg_change_inner_to_outer = to annotate the {$item}, change the doc comment from inner to outer style

+parse_invalid_attr_unsafe = `{$name}` is not an unsafe attribute
+    .suggestion = remove the `unsafe(...)`
+    .note = extraneous unsafe is not allowed in attributes


Discussion: should this say something like "unsafe attribute block is not permitted for safe attributes"?

compiler/rustc_parse/messages.ftl

compiler/rustc_parse/src/validate_attr.rs

jieyouxu · 2024-06-09T17:26:05Z

@rustbot author

carbotaniuman · 2024-06-16T07:56:16Z

@rustbot reviewer

jieyouxu

Thank you for working on this. The implementation looks good to me! Just one nit on the lint docs then r=me.

compiler/rustc_lint_defs/src/builtin.rs

compiler/rustc_parse/messages.ftl

@@ -364,6 +364,10 @@ parse_inner_doc_comment_not_permitted = expected outer doc comment
    .label_does_not_annotate_this = the inner doc comment doesn't annotate this {$item}
    .sugg_change_inner_to_outer = to annotate the {$item}, change the doc comment from inner to outer style

+parse_invalid_attr_unsafe = `{$name}` is not an unsafe attribute
+    .suggestion = remove the `unsafe(...)`
+    .note = extraneous unsafe is not allowed in attributes


jieyouxu · 2024-06-16T21:48:21Z

@rustbot author

bors · 2024-06-17T07:29:11Z

☔ The latest upstream changes (presumably #126569) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu · 2024-06-17T16:55:13Z

r=me with a rebase, but not going to block on the tiny comment nit.

carbotaniuman · 2024-06-24T01:09:41Z

@rustbot reviewer

jieyouxu

Thanks!

jieyouxu · 2024-06-24T01:48:13Z

@bors r+

bors · 2024-06-24T01:48:15Z

📌 Commit a23917c has been approved by jieyouxu

It is now in the queue for this repository.

…r=jieyouxu Add hard error and migration lint for unsafe attrs More implementation work for rust-lang#123757 This adds the migration lint for unsafe attributes, as well as making it a hard error in Rust 2024.

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#126177 (Add hard error and migration lint for unsafe attrs) - rust-lang#126298 (Promote loongarch64-unknown-linux-musl to Tier 2 with host tools) - rust-lang#126455 (For [E0308]: mismatched types, when expr is in an arm's body, not add semicolon ';' at the end of it.) - rust-lang#126754 (Implement `use<>` formatting in rustfmt) - rust-lang#126807 (std::unix::fs: copy simplification for apple.) - rust-lang#126845 (Weekly `cargo update`) - rust-lang#126849 (Fix 32-bit Arm reg classes by hierarchically sorting them) - rust-lang#126854 (std::unix::os::home_dir: fallback's optimisation.) - rust-lang#126861 (Migrate `run-make/invalid-library` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#126177 (Add hard error and migration lint for unsafe attrs) - rust-lang#126298 (Promote loongarch64-unknown-linux-musl to Tier 2 with host tools) - rust-lang#126455 (For [E0308]: mismatched types, when expr is in an arm's body, not add semicolon ';' at the end of it.) - rust-lang#126754 (Implement `use<>` formatting in rustfmt) - rust-lang#126807 (std::unix::fs: copy simplification for apple.) - rust-lang#126845 (Weekly `cargo update`) - rust-lang#126849 (Fix 32-bit Arm reg classes by hierarchically sorting them) - rust-lang#126854 (std::unix::os::home_dir: fallback's optimisation.) - rust-lang#126888 (Remove stray println from rustfmt's `rewrite_static`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#126177 - carbotaniuman:unsafe_attr_errors, r=jieyouxu Add hard error and migration lint for unsafe attrs More implementation work for rust-lang#123757 This adds the migration lint for unsafe attributes, as well as making it a hard error in Rust 2024.

rustbot assigned jieyouxu Jun 8, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2024

traviscross mentioned this pull request Jun 8, 2024

Tracking Issue for RFC 3325: unsafe attributes #123757

Open

8 tasks

This comment has been minimized.

Sign in to view

carbotaniuman force-pushed the unsafe_attr_errors branch from 643bc06 to 86c52d6 Compare June 9, 2024 00:23

This comment has been minimized.

Sign in to view

carbotaniuman force-pushed the unsafe_attr_errors branch from 86c52d6 to e86eaae Compare June 9, 2024 01:18

This comment has been minimized.

Sign in to view

carbotaniuman force-pushed the unsafe_attr_errors branch from e86eaae to 9d329c0 Compare June 9, 2024 03:49

jieyouxu reviewed Jun 9, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2024

jieyouxu added L-unsafe_attr_outside_unsafe Lint: unsafe_attr_outside_unsafe F-unsafe_attributes `#![feature(unsafe_attributes)]` labels Jun 9, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 16, 2024

jieyouxu approved these changes Jun 16, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2024

ehuss mentioned this pull request Jun 20, 2024

Add 2024 unsafe attributes. rust-lang/edition-guide#308

Merged

carbotaniuman force-pushed the unsafe_attr_errors branch from 2d0a3dc to 6c14e9e Compare June 23, 2024 23:50

This comment has been minimized.

Sign in to view

Add hard error and migration lint for unsafe attrs

a23917c

carbotaniuman force-pushed the unsafe_attr_errors branch from 6c14e9e to a23917c Compare June 24, 2024 00:02

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2024

jieyouxu approved these changes Jun 24, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2024

workingjubilee mentioned this pull request Jun 24, 2024

Rollup of 9 pull requests #126886

Closed

matthiaskrgr mentioned this pull request Jun 24, 2024

Rollup of 9 pull requests #126891

Merged

bors merged commit 9a591ea into rust-lang:master Jun 24, 2024
6 checks passed

rustbot added this to the 1.81.0 milestone Jun 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add hard error and migration lint for unsafe attrs #126177

Add hard error and migration lint for unsafe attrs #126177

carbotaniuman commented Jun 8, 2024

rustbot commented Jun 8, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jieyouxu left a comment

jieyouxu Jun 9, 2024

This comment was marked as resolved.

jieyouxu commented Jun 9, 2024

carbotaniuman commented Jun 16, 2024

jieyouxu left a comment •

edited

Loading

This comment was marked as resolved.

jieyouxu commented Jun 16, 2024

bors commented Jun 17, 2024

jieyouxu commented Jun 17, 2024 •

edited

Loading

This comment has been minimized.

carbotaniuman commented Jun 24, 2024

jieyouxu left a comment

jieyouxu commented Jun 24, 2024

bors commented Jun 24, 2024

Add hard error and migration lint for unsafe attrs #126177

Add hard error and migration lint for unsafe attrs #126177

Conversation

carbotaniuman commented Jun 8, 2024

rustbot commented Jun 8, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu Jun 9, 2024

Choose a reason for hiding this comment

This comment was marked as resolved.

jieyouxu commented Jun 9, 2024

carbotaniuman commented Jun 16, 2024

jieyouxu left a comment • edited Loading

Choose a reason for hiding this comment

This comment was marked as resolved.

jieyouxu commented Jun 16, 2024

bors commented Jun 17, 2024

jieyouxu commented Jun 17, 2024 • edited Loading

This comment has been minimized.

carbotaniuman commented Jun 24, 2024

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu commented Jun 24, 2024

bors commented Jun 24, 2024

jieyouxu left a comment •

edited

Loading

jieyouxu commented Jun 17, 2024 •

edited

Loading