Remove failing GUI test to stop blocking CI until it is fixed #126445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ cc @matthiaskrgr we can bump the prio to whatever’s needed to override the tree close prio, when the tools builder is green 🤞 |
|
🌲 The tree is currently closed for pull requests below priority 13. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jun 13, 2024
Remove failing GUI test to stop blocking CI until it is fixed Until rust-lang#126436 is solved, let's unblock rust CI. r? `@lqd`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2024
…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#121216 (Always emit `native-static-libs` note, even if it is empty) - rust-lang#123726 (Clarify `Command::new` behavior for programs with arguments) - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#126088 ([1/2] clean-up / general improvements) - rust-lang#126390 (Fix wording in {checked_}next_power_of_two) - rust-lang#126392 (Small style improvement in `gvn.rs`) - rust-lang#126402 (Fix wrong `assert_unsafe_precondition` message for `core::ptr::copy`) - rust-lang#126445 (Remove failing GUI test to stop blocking CI until it is fixed) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2024
…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#121216 (Always emit `native-static-libs` note, even if it is empty) - rust-lang#123726 (Clarify `Command::new` behavior for programs with arguments) - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#126088 ([1/2] clean-up / general improvements) - rust-lang#126390 (Fix wording in {checked_}next_power_of_two) - rust-lang#126392 (Small style improvement in `gvn.rs`) - rust-lang#126402 (Fix wrong `assert_unsafe_precondition` message for `core::ptr::copy`) - rust-lang#126445 (Remove failing GUI test to stop blocking CI until it is fixed) r? `@ghost` `@rustbot` modify labels: rollup
|
@bors p=14 |
|
☀️ Test successful - checks-actions |
|
@bors treeclosed- |
|
Finished benchmarking commit (0ef0dd2): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (secondary -5.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -3.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.518s -> 671.505s (-0.00%) |
|
This also hit beta in #126453, so I'm going to unilaterally backport the removal. |
cuviper
added
the
beta-accepted
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
[beta] backports and stage0 bump - Bump stage0 to 1.79.0 - Do not define opaque types when selecting impls rust-lang#126258 - Remove failing GUI test to stop blocking CI until it is fixed rust-lang#126445 r? cuviper
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 1, 2024
…iddle Add back `help-page.goml` rustdoc GUI test Since rust-lang#127010 was merged, let's see if we can revert rust-lang#126445... r? `@notriddle`
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Jul 2, 2024
Add back `help-page.goml` rustdoc GUI test Since rust-lang/rust#127010 was merged, let's see if we can revert rust-lang/rust#126445... r? `@notriddle`
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Jul 11, 2024
Add back `help-page.goml` rustdoc GUI test Since rust-lang/rust#127010 was merged, let's see if we can revert rust-lang/rust#126445... r? `@notriddle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until #126436 is solved, let's unblock rust CI.
r? @lqd