Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate run-make/dep-graph to rmake.rs #126517

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

GuillaumeGomez
Copy link
Member

Part of #121876.

r? @jieyouxu

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 15, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 15, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one nit, feel free to r=me with or without fixing it.

tests/run-make/dep-graph/rmake.rs Outdated Show resolved Hide resolved
@Kobzol
Copy link
Contributor

Kobzol commented Jun 15, 2024

r? @Kobzol

@rustbot rustbot assigned Kobzol and unassigned jieyouxu Jun 15, 2024
@GuillaumeGomez
Copy link
Member Author

No, this nit needed to be fixed! And this is now done. :D

@Kobzol
Copy link
Contributor

Kobzol commented Jun 15, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 15, 2024

📌 Commit a4eaf87 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2024
…llaumeGomez

Rollup of 9 pull requests

Successful merges:

 - rust-lang#126229 (Bump windows-bindgen to 0.57)
 - rust-lang#126404 (Check that alias-relate terms are WF if reporting an error in alias-relate)
 - rust-lang#126410 (smir: merge identical Constant and ConstOperand types)
 - rust-lang#126478 (Migrate `run-make/codegen-options-parsing` to `rmake.rs`)
 - rust-lang#126496 (Make proof tree probing and `Candidate`/`CandidateSource` generic over interner)
 - rust-lang#126508 (Make uninitialized_error_reported a set of locals)
 - rust-lang#126517 (Migrate `run-make/dep-graph` to `rmake.rs`)
 - rust-lang#126525 (trait_selection: remove extra words)
 - rust-lang#126526 (tests/ui/lint: Move 19 tests to new `non-snake-case` subdir)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 38b3c9a into rust-lang:master Jun 15, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2024
Rollup merge of rust-lang#126517 - GuillaumeGomez:migrate-run-make-dep-graph, r=Kobzol

Migrate `run-make/dep-graph` to `rmake.rs`

Part of rust-lang#121876.

r? `@jieyouxu`
@GuillaumeGomez GuillaumeGomez deleted the migrate-run-make-dep-graph branch June 16, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants